Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment: Fix minor versioning issues #54

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Teufelchen1
Copy link

Hi 🦤,

this fixes some issues that prevented make to work.

  1. The log level needs to be capital. Otherwise the logging initialization will fail.
  2. Pinning the container os: Two weeks in a row, ubuntu:latest did not work for me. Today it started working again...anyway, we can pin to a LTS version.
  3. pydantic 2.0 did a big rework and I think it is no longer compatible? I guessed this version and could only do limited testing :/ if other maintainers could check which version is running on their machines, that would be great!
  4. PWD is the only absolute value in the compose file. Replacing it with a relative path to be in line with the rest. (This one gave me a headache)

@aabadie
Copy link
Contributor

aabadie commented Nov 27, 2024

How about making the code compatible with pydantic and latest ubuntu versions? I fear that otherwise the current state will rot quite a bit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants