Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

facebook/zstd to submodule #7

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

keewon
Copy link

@keewon keewon commented Feb 10, 2020

Thanks for writing zstd-erlang.
I wanted to use latest zstd, but it seems that this repository contains zstd 1.3.3 itself.
This PR changes priv/zstd to git submodule.

How I verified

$ git submodule update --init
$ rebar g-d
$ rebar co
$ erl -pa ebin
1> Compressed = zstd:compress(<<"Hello, World!">>).
<<40,181,47,253,32,13,105,0,0,72,101,108,108,111,44,32,87,
  111,114,108,100,33>>
2> zstd:decompress(Compressed).
<<"Hello, World!">>

How I added this one to my Elixir project (mix.exs)

{:zstd, github: "keewon/zstd-erlang", branch: "zstd_to_submodule", submodules: true},

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant