Add inverted noteBackgroundColor #22486
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
| @@ -210,7 +210,7 @@ Color EngravingConfiguration::thumbnailBackgroundColor() const | |||
|
|
|||
| Color EngravingConfiguration::noteBackgroundColor() const | |||
| { | |||
| return Color::WHITE; | |||
| return notationConfiguration()->foregroundColor(); | |||
There was a problem hiding this comment.
This solution is not ideal... It creates bad dependencies between the modules. The notation module should depend on the engraving module, and not vice versa
There was a problem hiding this comment.
(no such concerns had been raised with the original PR)
How to change?
|
The vtest diffs show that a 'different shade of white' is used as background for the notehead parentheses. Seems to match my comments #16715 (comment) and #16830 (comment) |
Jojo-Schmitz
force-pushed
the
invert-note-backgrounds
branch
2 times, most recently
from
aa91b13 to
1c263a2
Compare
Jojo-Schmitz
force-pushed
the
invert-note-backgrounds
branch
from
1c263a2 to
c934ffb
Compare
Jojo-Schmitz
force-pushed
the
invert-note-backgrounds
branch
from
c934ffb to
3f0f8e6
Compare
Jojo-Schmitz
force-pushed
the
invert-note-backgrounds
branch
from
3f0f8e6 to
622cb12
Compare
|
No longer needed apparently |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase of #16830
Resolves: https://musescore.org/en/node/346509