Added fretboard diagram legend box #26225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eism
force-pushed
the
fret_diagram_legend
branch
from
30fca22 to
b25a74f
Compare
Eism
force-pushed
the
fret_diagram_legend
branch
from
b25a74f to
b920ca6
Compare
Eism
force-pushed
the
fret_diagram_legend
branch
from
b920ca6 to
eb17522
Compare
mike-spa
reviewed
Jan 27, 2025
|
Also (this is an engraving comment, not a coding comment 😄) it would be good to set the default bottom padding to 2sp or something like that, in order to avoid "touching" between diagrams in the legend and in the score.
|
Eism
force-pushed
the
fret_diagram_legend
branch
from
eb17522 to
ec40924
Compare
Eism
force-pushed
the
fret_diagram_legend
branch
from
ec40924 to
3b6688a
Compare
mike-spa
approved these changes
Feb 20, 2025
|
Engraving refinements task: #26641 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first part of #26042
Screen.Recording.2025-01-27.at.2.22.26.PM.mov