Fix crash on drop time sig or key sig #26427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix assert failure on edge case no instrument
oktophonie
approved these changes
Feb 10, 2025
|
Can't check right now, but I'm afraid this reintroduces issue 1 from #24147 (comment). |
Ok thanks, I'll try to look into that if I have a moment. |
Update: it did in fact reintroduce that issue, so I've made an alternative solution in the last commit. @avvvvve best if you double check that one too :) |
|
late, but looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #26423
Resolves: #26414
Resolves: #25395
@cbjeukendrup
EditData::dropElementcan't be used after the drop, because it is often deleted during the drop itself (see for instanceMeasure::dropon the caseElementType::KEYSIG). In turn, it's thedropmethod which returns (if possible) the element to be selected after the drop, and the selection is already done inNotationInteraction::doDropStandardandNotationInteraction::doDropTextBaseAndSymbolsso it shouldn't be necessary to do it here too.The last issue is not a real issue, just an assert failure on an edge case that's only relevant with debug builds, but I've fixed it anyway.