Fix #23446: Playback artifact when solo-ing instruments (MuseSounds) #26585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathesoncalum
approved these changes
Feb 19, 2025
This comment was marked as outdated.
This comment was marked as outdated.
1. calculate isSilence more efficiently 2. don't write silent buffers to final output buffer to avoid unnecessary mixOutputFromChannel() calls
…ss remaining samples And skip the channel when it gets completely silent
RomanPudashkin
force-pushed
the
musesampler_solo_mute_artifacts_fix
branch
from
aaaa88d to
4c05404
Compare
|
Just out of curiosity: does the optimisation also apply to audio exports (should it speed up exports)? |
Yes, it should. Especially if there are a lot of rests in your score |
|
Tested on MacOS 15, Windows 11, Ubuntu 22.04.3. Approved |
Good to hear! I had tested the current build on this toy score and hadn't found any difference though (hence my question). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #23446