Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct barline on oneline to hidden staff #26686

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sammik
Copy link
Contributor

@sammik sammik commented Feb 23, 2025

Resolves #26675

  1. commit: missing bottom half of single line staff barline

  2. commit: barlines overlapping, and cleanup - now span thru barlines always starts at top line, and ends at next staff top line
    dotted_dashed

also it is now possible to customise bottom of barline at singe line staff
singleline-bottom

vtests are, I think good

not sure just about one. I think it is good now, but may be I miss something
before:
barline-6-1 ref

after:
barline-6-1

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Feb 23, 2025
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1-line stave barline missing the lower half if spanning to a hidden stave
1 participant