Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do all #13

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

do all #13

wants to merge 2 commits into from

Conversation

Dmitry-Ivashkov
Copy link

@Dmitry-Ivashkov
do all,
1d25dd1 
test: Ok
@Dmitry-Ivashkov
сделал main
72c57ea 
поправил тесты
mutcianm
mutcianm reviewed Feb 17, 2021
View reviewed changes
1/practice/src/main/scala/org/spbsu/mkn/scala/TheGame.scala
// def generateNumberString(length: Int): String = alphanumeric.drop(length).toString() // если эксклюзивность не важна
def generateNumberString(length: Int): String = { // a-z A-Z 0-9
if (length < 1) return ""
val some_string = generateNumberString(length - 1)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting solution

mutcianm
mutcianm reviewed Feb 17, 2021
View reviewed changes
1/practice/src/main/scala/org/spbsu/mkn/scala/TheGame.scala
var secret = generateNumberString(length)
var guessResult: GuessResult = Incorrect(0, 0)
var numTries = 0
while (guessResult.isInstanceOf[TheGame.Incorrect]) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be re-implemented as a tail-recursive function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mutcianm mutcianm mutcianm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dmitry-Ivashkov @mutcianm