update: use bandwidth metering when cache is enabled #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need to change the
DefaultBandwidthMeter
because theDataSource
is entirely responsible for reporting its own bandwidth stats. The approach we take instead is to report data transfer only when theDataSource
is transferring from a remote data source.MuxDataSource
never reports its own data transfer stats. Instead it attaches theBandwidthMeter
to theDataSource
s delegated-to, which are responsible for reporting their stats normally.RevalidatingDataSource
reports its own stats directly only if we have a response body to download (eg, an expired entry)