-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Releases/v0.14.0 #41
Merged
Merged
Releases/v0.14.0 #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: update dependencies, bump minor version * chore: cleanup * switch to plain text in LICENSE * move run-tests script to scripts * remove unnecessary example files * stop tracking Podfile.lock changes * stop tracking Pods directory content changes * remove old comment about travis CI, it is no longer used * test: move unit tests out of demo app into package * test: replace IMA tests refactor: use init instead of new * test: remove Specta tests, replaced 1-1 with XCTest * chore: updated example
c37e0b3
to
8fb7d27
Compare
buildkite tbd
8fb7d27
to
e58da4d
Compare
* keep prior API, propagate all calls to it through to the new one transparently
andrewjl-mux
commented
Oct 30, 2024
Need to write a brief migration guide here. It will automatically be moved onto the GH release. Optionally, we can also add a note about it to the dev guide |
A draft release has been created for this version. Find it here! https://github.com/muxinc/mux-stats-google-ima/releases/tag/untagged-cf43021e5a42f1ffeb4d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking
MuxImaListener
API to improve data accuracy (see below) (proposal: monitor IMA ad events for the user #42)Improvements:
Steps to migrate existing integration
MuxImaLister
withMUXSDKIMAAdListener
.MuxImaListener
supports the same new API so this step is optional, the remaining steps are applicable toMuxImaListener
. As ofv0.14.0
,MuxImaLister
is deprecated and will be removed in a future release.IMAAdsLoader
when calling theMUXSDKIMAAdListener
initializer. Make sure your IMAAdsLoader delegate is configured before this step.IMAAdsLoaderDelegate
calls to your delegate.IMAAdsManager
, like you've done withIMAAdsLoader
, configure your ownIMAAdsManagerDelegate
first and then callmonitorAdsManager
.IMAAdsManagerDelegate
calls to your delegate.dispatchEvent
,dispatchError
, andonContentPauseOrResume
from your integration.