Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update example with additional ad variants and custom inputs #46

Merged
merged 9 commits into from
Nov 8, 2024
Merged

chore: update example with additional ad variants and custom inputs #46

merged 9 commits into from
Nov 8, 2024

Conversation

andrewjl-mux
Copy link
Contributor

@andrewjl-mux andrewjl-mux commented Nov 6, 2024 •
edited
Loading

  • Add list of additional ad tag url variants to SPM example
  • Add UI for configuring arbitrary ad tag URL, content URL, and Mux Data environment key to SPM example
  • Add script to build an application archive of the SPM example that can be uploaded to Sauce Labs for testing on physical devices
  • Configure BuildKite pipeline to create and upload SPM example

Follow-ups for separate PR

  • Migrate GHA CI checks and release artifact creation to BuildKite
  • Clean-up the other iOS and tvOS Cocoapods examples

@andrewjl-mux
update .gitignore
e1f76fa 
chore: update example

ci: add script to archive example package

update .gitignore
@andrewjl-mux andrewjl-mux requested a review from a team as a code owner November 6, 2024 17:05
@andrewjl-mux andrewjl-mux force-pushed the ajlb/improved-example branch from 3ff60fd to 6e45a07 Compare November 6, 2024 18:07
daytime-em
daytime-em requested changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@daytime-em daytime-em left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Odd comment in the examples, looks like it was truncated at some point

...PluginSPMExampleIOS/MuxStatsGoogleIMAPluginSPMExampleIOS/PlayerContainerViewController.swift Outdated Show resolved Hide resolved
@andrewjl-mux andrewjl-mux requested review from daytime-em and a team November 7, 2024 21:12
@andrewjl-mux andrewjl-mux merged commit 828fb59 into releases/v0.15.0 Nov 8, 2024
3 checks passed
@andrewjl-mux andrewjl-mux deleted the ajlb/improved-example branch November 8, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daytime-em daytime-em daytime-em approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewjl-mux @daytime-em