Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatability with aiohttp>=3 #713

Closed
wants to merge 1 commit into from
Closed

Conversation

atx
Copy link

@atx atx commented Mar 22, 2018

Note that this might be a breaking change - not sure what your policy is on that.

@decaz
Copy link

decaz commented Apr 19, 2018

@atx can you make some fixes so tests will pass?

@codecov
Copy link

codecov bot commented Apr 22, 2018

Codecov Report

Merging #713 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #713   +/-   ##
=======================================
  Coverage   89.02%   89.02%           
=======================================
  Files          61       61           
  Lines        4646     4646           
  Branches      818      818           
=======================================
  Hits         4136     4136           
  Misses        332      332           
  Partials      178      178

aiohttp.Timeout is no longer available
@atx
Copy link
Author

atx commented Apr 22, 2018

Oops, completely forgot about this - fixed.

The remaning test failures seem to be caused by Tornado 5.0 (testing with 4.5.3 works).

@vdboor
Copy link
Contributor

vdboor commented Apr 26, 2018

@atx is there any advantage of specifying the timeout over what I've done in PR #735?

At least PR #735 would remain backwards compatible.

@atx
Copy link
Author

atx commented Apr 26, 2018

I don't think there is. aiohttp itself does some more complicated stuff with its timeout code but it's not obvious to me if it really matters.

@mvantellingen
Copy link
Owner

I think this was a duplicate with #735 right? I've merged that one before reviewing this one (sorry)

@dirkmb
Copy link

dirkmb commented May 28, 2018

besides the fact that #735 missed to change the get-method of AsyncTransport, which still uses aiohttp.Timeout
#764 resolves this problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants