Use a "-" as a delimeter for filenames of temporary files

[lrlunin]

Based on the issue #1289 I propose a solution using the "-" (minus) instead of "_" (underscore) for the delimiter of original filename and filename of temporary file.

I suggest to take "-" since the "safe" characters to use in filename for all platforms are [0-9a-zA-Z-._] while the "_" already interferes with poor chosen python temp filename naming sequence characters. I would also do not take "." since it is already used for the file extension on the right and is more error prone if the file has no extension prefix.

This let us basically only with the "-" as a valid character.

Thanks!

[github-actions]

Thank you for making this pull request.

Did you know? You can try it on Binder: or .

Also, the version of Jupytext developed in this PR can be installed with pip:

HATCH_BUILD_HOOKS_ENABLE=true pip install git+https://github.com/lrlunin/jupytext.git@main

(this requires nodejs, see more at Developing Jupytext)

[mwouts]

That's fine by me. Thanks for looking into this! Before I merge I will make sure the tests pass (not sure why they were not triggered 🤔 )

[lrlunin]

not sure why they were not triggered 🤔

I guess because I am making the 1st pull-request in this repo you need to permit to CI actions to execute. For me it says:

This workflow is awaiting approval from a maintainer in #1296

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.02%. Comparing base (d0e5b7a) to head (592ef82).
Report is 3 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1296   +/-   ##
=======================================
  Coverage   97.02%   97.02%           
=======================================
  Files          29       29           
  Lines        4501     4501           
=======================================
  Hits         4367     4367           
  Misses        134      134           

Flag	Coverage Δ
external	74.94% <100.00%> (-0.10%)	⬇️
functional	88.35% <100.00%> (ø)
integration	77.27% <0.00%> (ø)
unit	66.45% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[lrlunin]

I am now wondering if it still makes sense to choose either from " " and "-" depending if spaces are in original filenames. Maybe then always use "-" as delimeter. Otherwise the steps to obtain the original filename would be different if there were spaces in it or not.

[mwouts]

Thanks, yes I do prefer that version too!

[lrlunin]

Since this is still my first pull-request you need to approve this workflow again :-)

[mwouts]

Oh I understood what's happening here! I don't get to see the button when I use the "new merge experience"...

[lrlunin]

I believe that this PR is not responsible for the code test coverage drop below 97% 😨

[mwouts]

I believe that this PR is not responsible for the code test coverage drop below 97% 😨

np, I will look into that later on. Thanks for your PR!