This repository has been archived by the owner on May 26, 2022. It is now read-only.
Do not look for goog.provide/require in comments #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a workaround for the issue mxmul#16 "Incorrectly finds `goog.require` and `goog.provide` statements in comments"
mxmul
suggested changes
Mar 24, 2019
| let source = originalSource; | ||
| let source = originalSource | ||
| //.replace(/\/\/.*/g, '') // remove line comments (somehow this bugs) | ||
| .replace(/\/\*[^]*?\*\//g, '/* stripped comment */'); // block comments |
There was a problem hiding this comment.
Is [^]* equivalent to .*? More readable as the latter if so
There was a problem hiding this comment.
Hi
I just took people comments and made a PR. I was not even sure that you would answer. Now that I know I will take the time to understand and fix everything :)
Thank you for your feedback
| @@ -205,7 +205,10 @@ function createPrefix(loaderContext, globalVarTree, globalVars, useEval) { | |||
| module.exports = function loader(originalSource, inputSourceMap) { | |||
| const self = this; | |||
| const callback = this.async(); | |||
| let source = originalSource; | |||
| let source = originalSource | |||
| //.replace(/\/\/.*/g, '') // remove line comments (somehow this bugs) | |||
There was a problem hiding this comment.
Seems like this would strip everything in the source file after the first comment. You probably only want to match until EOL.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround for the issue #16 "Incorrectly finds
goog.requireandgoog.providestatements in comments"