dev: rename TransferAccountRequest param (#65)

* rename TransferAccountRequest param from to to address * fmt constants.go
mycel-labs · Nov 1, 2024 · abd1faa · abd1faa
1 parent 42e68cf
commit abd1faa
Show file tree

Hide file tree

Showing 7 changed files with 200 additions and 197 deletions.
diff --git a/docs/api.md b/docs/api.md
@@ -436,7 +436,7 @@ Requests
 | Field | Type | Label | Description |
 | ----- | ---- | ----- | ----------- |
 | base | [AccountOperationRequest](#api-v1-AccountOperationRequest) |  |  |
-| to | [string](#string) |  |  |
+| address | [string](#string) |  |  |
 
 
 

diff --git a/src/go/pb/api/v1/transferable_account.pb.go b/src/go/pb/api/v1/transferable_account.pb.go
diff --git a/src/go/server/server.go b/src/go/server/server.go
@@ -228,7 +228,7 @@ func (s *server) TransferAccount(ctx context.Context, req *pb.TransferAccountReq
 		return nil, err
 	}
 
-	tx, err := s.taStoreContractBind.TransferAccount(s.auth, *sig, req.Base.AccountId, common.HexToAddress(req.To))
+	tx, err := s.taStoreContractBind.TransferAccount(s.auth, *sig, req.Base.AccountId, common.HexToAddress(req.Address))
 	if err != nil {
 		log.Printf("err: %v", err)
 		return nil, err

diff --git a/src/go/server/server_test.go b/src/go/server/server_test.go
@@ -136,6 +136,8 @@ func TestIsApproved(t *testing.T) {
 	}
 	log.Printf("tx: %v", tx)
 
+	time.Sleep(2 * time.Second)
+
 	// Test cases
 	testCases := []struct {
 		name      string
@@ -227,7 +229,7 @@ func TestTransferAccount(t *testing.T) {
 					AccountId: tc.accountId,
 					Proof:     sig,
 				},
-				To: tc.to,
+				Address: tc.to,
 			}
 			resp, err := s.TransferAccount(context.Background(), req)
 

diff --git a/src/proto/api/v1/transferable_account.proto b/src/proto/api/v1/transferable_account.proto
@@ -43,7 +43,7 @@ message CreateAccountRequest {
 
 message TransferAccountRequest {
     AccountOperationRequest base = 1;
-    string to = 2;
+    string address = 2;
 }
 
 message DeleteAccountRequest {

diff --git a/test/e2e/e2e_test.go b/test/e2e/e2e_test.go
@@ -157,7 +157,7 @@ func TestTransferAccountE2E(t *testing.T) {
 					AccountId: accountId,
 					Proof:     transferSig,
 				},
-				To: tc.to,
+				Address: tc.to,
 			}
 			_, resp, err := testutil.TransferAccount(request)
 			if tc.expectValid && err != nil {
@@ -361,7 +361,7 @@ func TestApproveAddressE2E(t *testing.T) {
 						AccountId: accountId,
 						Proof:     transferSig,
 					},
-					To: tc.to.PublicKey.X.String(),
+					Address: tc.to.PublicKey.X.String(),
 				}
 				_, resp, err = testutil.TransferAccount(transferRequest)
 				if err != nil {
@@ -447,7 +447,7 @@ func TestRevokeApprovalE2E(t *testing.T) {
 						AccountId: accountId,
 						Proof:     transferSig,
 					},
-					To: tc.to.PublicKey.X.String(),
+					Address: tc.to.PublicKey.X.String(),
 				}
 				_, resp, err = testutil.TransferAccount(transferRequest)
 				assert.Error(t, err)

diff --git a/test/utils/contants.go b/test/utils/contants.go
@@ -3,5 +3,5 @@ package testutil
 const (
 	TAStoreContractPath = "TransferableAccountStore.sol/TransferableAccountStore.json"
 	FundedAddress       = "0xBE69d72ca5f88aCba033a063dF5DBe43a4148De0"
-	HostURL = "http://localhost:8080"
+	HostURL             = "http://localhost:8080"
 )