Skip to content
This repository has been archived by the owner on Oct 24, 2024. It is now read-only.

Feat/add text record #114

Merged
merged 6 commits into from
Dec 19, 2023
Merged

Feat/add text record #114

merged 6 commits into from
Dec 19, 2023

Conversation

taryune
Copy link
Member

@taryune taryune commented Dec 14, 2023

No description provided.

@taryune taryune marked this pull request as ready for review December 14, 2023 13:03
Copy link
Member

@foxytanuki foxytanuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Please fix the small corrections I pointed out.

Comment on lines +32 to +37
params := &types.QueryTextRecordRequest{

DomainName: reqDomainName,
DomainParent: reqDomainParent,
Key: reqKey,
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
params := &types.QueryTextRecordRequest{
DomainName: reqDomainName,
DomainParent: reqDomainParent,
Key: reqKey,
}
params := &types.QueryTextRecordRequest{
DomainName: reqDomainName,
DomainParent: reqDomainParent,
Key: reqKey,
}

@taryune taryune merged commit 21ef618 into main Dec 19, 2023
3 checks passed
@taryune taryune deleted the feat/add-text-record branch December 19, 2023 02:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants