This repository has been archived by the owner on Oct 24, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e registration-policy --module registry`
…istration_policy_test.go
foxytanuki
force-pushed
the
feat/foxy-tld-registration-control
branch
from
December 23, 2023 05:13
38c3a6c
to
84a1d02
Compare
taryune
reviewed
Dec 25, 2023
taryune
approved these changes
Dec 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
Protobuf Modifications: Added a RegistrationPolicyType enum and a RegistrationPolicy field to the TopLevelDomain message in top_level_domain.proto.
Keeper Method Updates: Implemented UpdateTopLevelDomainRegistrationPolicy with testing and added relevant events.
SLD Registration Validation: Included validation in SLD registration methods to require a public TLD registration policy.
Update QueryDomainRegistrationFeeRequest message