Skip to content
This repository has been archived by the owner on Oct 24, 2024. It is now read-only.

Remove Record Params from QueryGetSecondLevelDomainResponse #98

Merged
merged 7 commits into from
Oct 18, 2023

Conversation

taryune
Copy link
Member

@taryune taryune commented Oct 17, 2023

Test

  • Register and update records
myceld tx registry register-second-level-domain hoge cel 1 --from alice  -y

myceld tx registry update-wallet-record hoge cel ETHEREUM_MAINNET_MAINNET 0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92277 --from alice -y 
 
myceld tx registry update-dns-record hoge cel A 142.250.207.49 --from alice -y 

myceld tx registry update-dns-record hoge cel CNAME www.google.com --from alice -y 
  • Query all domain
myceld q registry list-second-level-domain   

Response (Should be return only domain name and expiration date):

pagination:
  next_key: null
  total: "0"
secondLevelDomain:
- expirationDate: "1729171384544002000"
  name: hoge
  parent: cel

  • Query hoge.cel
myceld q registry show-second-level-domain hoge cel    

Response:

secondLevelDomain:
  expirationDate: "1729171384544002000"
  name: hoge
  parent: cel
  • Query all records
 myceld q resolver all-records hoge cel            

Response:

values:
  A:
    dnsRecord:
      dnsRecordType: A
      value: 142.250.207.49
  CNAME:
    dnsRecord:
      dnsRecordType: CNAME
      value: www.google.com
  ETHEREUM_MAINNET_MAINNET:
    walletRecord:
      value: 0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92277
      walletRecordType: ETHEREUM_MAINNET_MAINNET

@taryune taryune changed the title Remove Record Params from QueryGetSecondLevelDomainResponse [WIP]Remove Record Params from QueryGetSecondLevelDomainResponse Oct 17, 2023
@taryune taryune changed the title [WIP]Remove Record Params from QueryGetSecondLevelDomainResponse Remove Record Params from QueryGetSecondLevelDomainResponse Oct 17, 2023
@taryune taryune requested a review from yujiym October 17, 2023 16:25
Copy link
Contributor

@yujiym yujiym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM!
✨ commis are clean and easy to understand.

@yujiym yujiym merged commit c08ff3c into main Oct 18, 2023
@taryune taryune deleted the fix/rm-sld-record-from-resp branch October 18, 2023 08:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove SLD Records Query Command at Registry
2 participants