Review Comments #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iflp
reviewed
Jun 21, 2022
| @@ -292,6 +299,7 @@ contract PoolStateHelper is IPoolStateHelper { | |||
| // Base case | |||
| finalExpectedPoolState = ExpectedPoolState({ | |||
| cumulativePendingMintSettlement: newPendingSettlement, | |||
| // note: why do we multiply out by decimals here? Is that not already factored into the settlement balance? | |||
There was a problem hiding this comment.
Due to integer division - there can be a scenario where long.settlementBalance < short.settlementBalance. Scaling by settlementTokenDecimals seemed a logical choice to me because shortPrice and longPrice are scaled the same way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Thought it would be easier to make comments and any changes via PR.