Update README.md #60
Open
Update README.md #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update DataBlockDataItem how to call the constructor according to 'refactor: Make DataBlockDataItem immutable except for it's value' commit
mycroes
reviewed
Jan 30, 2025
|
HI @AndreDrubig, thanks again for your help. I suggested a minor change (although this entire PR is a minor change), I hope you're willing to make the adjustment. |
|
Hi @mycroes, Yes you are right than it is in the correct order. Regards |
mycroes
reviewed
Jan 31, 2025
README.md
Outdated
| @@ -33,8 +33,8 @@ Read 10 bytes from DataBlock 87 starting at address 54 | |||
| ``` | |||
| var dataItem = new DataBlockDataItem<byte[]>( | |||
| dbNumber: 87, | |||
| length: 10, | |||
| startByte: 54 | |||
There was a problem hiding this comment.
Unfortunately the comma is on the wrong line now, preventing the sample code from compiling.
There was a problem hiding this comment.
Oh, what a stupid mistake. This happens when i am coding in the browser. Always those details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update DataBlockDataItem how to call the constructor according to 'refactor: Make DataBlockDataItem immutable except for it's value' commit