fix: pr feedback

myparcelnl · Nov 20, 2020 · cfa9eef · cfa9eef
1 parent e393561
commit cfa9eef
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 3 deletions.
diff --git a/src/delivery-options/components/RecursiveForm/RecursiveForm.vue b/src/delivery-options/components/RecursiveForm/RecursiveForm.vue
@@ -101,7 +101,7 @@
 
             <template v-if="$configBus.get(choice, 'price') !== 0">
               <span v-text="$configBus.get(choice, 'price') > 0 ? '+ ' : '– '" />
-              {{ formatCurrency(choice.price) }}
+              {{ formatCurrency($configBus.get(choice, 'price')) }}
             </template>
           </component>
         </label>

diff --git a/src/delivery-options/data/prices/formatCurrency.js b/src/delivery-options/data/prices/formatCurrency.js
@@ -8,8 +8,8 @@ import { configBus as realConfigBus } from '@/delivery-options/config/configBus'
  * @returns {String}
  */
 export function formatCurrency(price, configBus = realConfigBus) {
-  if (typeof price === 'string') {
-    price = configBus.get(price, 'price');
+  if (typeof price !== 'number') {
+    throw new Error('"price" must be a number.');
   }
 
   const formatter = new Intl.NumberFormat(

diff --git a/src/delivery-options/data/prices/getLowestPriceFromFormConfig.js b/src/delivery-options/data/prices/getLowestPriceFromFormConfig.js
@@ -28,5 +28,9 @@ export function getLowestPriceFromFormConfig(config, carrierName = null, configB
     })
     .flat();
 
+  if (!prices.length) {
+    throw new Error('"prices" array is empty.');
+  }
+
   return Math.min(...prices);
 }
diff --git a/tests/unit/delivery-options/components/RecursiveForm/RecursiveForm.spec.js b/tests/unit/delivery-options/components/RecursiveForm/RecursiveForm.spec.js
@@ -26,5 +26,6 @@ describe('RecursiveForm.vue', () => {
     expect(formatCurrency(0)).toBe('€ 0,00');
     expect(formatCurrency(100)).toBe('€ 100,00');
     expect(formatCurrency(24.50)).toBe('€ 24,50');
+    expect(formatCurrency(20000)).toBe('€ 20.000,00');
   });
 });