allow manual showing and hiding of the delivery options

myparcelnl · Oct 3, 2019 · e87984b · e87984b
1 parent 070760f
commit e87984b
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 11 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@myparcel/checkout",
-  "version": "3.0.17",
+  "version": "3.0.18",
   "types": "index.d.ts",
   "scripts": {
     "serve": "vue-cli-service serve",

diff --git a/src/App.vue b/src/App.vue
@@ -82,6 +82,15 @@ export default {
        * Event listeners object. Stored here so we can add and remove them easily.
        */
       listeners: {
+        show: () => {
+          this.showDeliveryOptions = true;
+          this.listeners.update();
+          document.addEventListener(EVENTS.UPDATE_DELIVERY_OPTIONS, this.listeners.update);
+        },
+        hide: () => {
+          this.showDeliveryOptions = false;
+          document.removeEventListener(EVENTS.UPDATE_DELIVERY_OPTIONS, this.listeners.update);
+        },
         update: debounce(this.getDeliveryOptions, debounceDelay),
         updateExternal: debounce(this.updateExternal, debounceDelay),
         error: (e) => {
@@ -96,10 +105,6 @@ export default {
   },
 
   computed: {
-    configBus() {
-      return this.$configBus;
-    },
-
     /**
      * False if:
      *  - CC is undefined
@@ -153,7 +158,7 @@ export default {
     hasSomethingToShow() {
       return this.$configBus.isValidCountry
         && (this.$configBus.isEnabledInAnyCarrier(ALLOW_PICKUP_LOCATIONS)
-        || this.$configBus.isEnabledInAnyCarrier(ALLOW_DELIVERY_OPTIONS));
+          || this.$configBus.isEnabledInAnyCarrier(ALLOW_DELIVERY_OPTIONS));
     },
 
     /**
@@ -169,8 +174,9 @@ export default {
   },
 
   created() {
-    this.listeners.update();
-    document.addEventListener(EVENTS.UPDATE_DELIVERY_OPTIONS, this.listeners.update);
+    this.listeners.show();
+    document.addEventListener(EVENTS.SHOW_DELIVERY_OPTIONS, this.listeners.show);
+    document.addEventListener(EVENTS.HIDE_DELIVERY_OPTIONS, this.listeners.hide);
 
     // Add the new data to the values object
     this.$configBus.$on(EVENTS.UPDATE, this.$configBus.updateExternalData);
@@ -288,7 +294,7 @@ export default {
         EVENTS.UPDATED_DELIVERY_OPTIONS,
         {
           detail: this.$configBus.exportValues,
-        }
+        },
       ));
     },
   },

diff --git a/src/config/data/eventConfig.js b/src/config/data/eventConfig.js
@@ -1,5 +1,5 @@
-/*
- * configBus events
+/**
+ * ConfigBus events.
  *
  * These are only used for and by the configBus so they don't need to be namespaced.
  */
@@ -57,3 +57,17 @@ export const UPDATED_ADDRESS = 'myparcel_updated_address';
  * @type {string}
  */
 export const UPDATED_DELIVERY_OPTIONS = 'myparcel_updated_delivery_options';
+
+/**
+ * Manually show the delivery options. The update listener has to be re-enabled after this.
+ *
+ * @type {String}
+ */
+export const SHOW_DELIVERY_OPTIONS = 'myparcel_show_delivery_options';
+
+/**
+ * Manually hide the delivery options. Should remove the update listener.
+ *
+ * @type {String}
+ */
+export const HIDE_DELIVERY_OPTIONS = 'myparcel_hide_delivery_options';