Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(errors): properly translate missing field error #217

Merged
merged 5 commits into from
Apr 16, 2024

Conversation

EdieLemoine
Copy link
Contributor

@EdieLemoine EdieLemoine commented Apr 15, 2024

INT-439

@EdieLemoine EdieLemoine requested a review from a team as a code owner April 15, 2024 14:56
Copy link

netlify bot commented Apr 15, 2024

Deploy Preview for myparcel-delivery-options ready!

Name Link
🔨 Latest commit f023b62
🔍 Latest deploy log https://app.netlify.com/sites/myparcel-delivery-options/deploys/661e84024774fa0008bf0ebe
😎 Deploy Preview https://deploy-preview-217--myparcel-delivery-options.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 87.01299% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 80.44%. Comparing base (a029c32) to head (f023b62).

Files Patch % Lines
...ps/delivery-options/src/composables/useLanguage.ts 80.00% 0 Missing and 5 partials ⚠️
libs/shared/src/composables/useApiExceptions.ts 86.84% 0 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #217      +/-   ##
==========================================
+ Coverage   80.27%   80.44%   +0.17%     
==========================================
  Files         354      354              
  Lines       11110    11173      +63     
  Branches      566      583      +17     
==========================================
+ Hits         8918     8988      +70     
+ Misses       1635     1611      -24     
- Partials      557      574      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EdieLemoine EdieLemoine force-pushed the fix/errors-translate-missing-field branch from 14b9b70 to 3c6bf36 Compare April 15, 2024 15:45
@myparcel-bot myparcel-bot bot force-pushed the fix/errors-translate-missing-field branch from 3c6bf36 to 4ca7228 Compare April 15, 2024 15:56
Copy link

codecov bot commented Apr 15, 2024

Bundle Report

Changes will increase total bundle size by 467 bytes ⬆️

Bundle name Size Change
@myparcel/delivery-options-MyParcelDeliveryOptionsLib 113.89kB 467 bytes ⬆️

@myparcel-bot myparcel-bot bot added the approved (Auto) label Apr 16, 2024
@myparcel-bot myparcel-bot bot force-pushed the fix/errors-translate-missing-field branch from 4ca7228 to 98924fb Compare April 16, 2024 13:33
@EdieLemoine EdieLemoine added this pull request to the merge queue Apr 16, 2024
Merged via the queue into main with commit 18379a4 Apr 16, 2024
12 checks passed
@EdieLemoine EdieLemoine deleted the fix/errors-translate-missing-field branch April 16, 2024 14:03
myparcel-bot bot added a commit that referenced this pull request Apr 16, 2024
## [@myparcel/delivery-options-v6.1.1](v6.1.0...v6.1.1) (2024-04-16)

### 🐛 Bug Fixes

* **errors:** properly translate missing field error ([#217](#217)) ([18379a4](18379a4))
* **pickup:** fix errors when creating map markers ([#221](#221)) ([d2a1dc9](d2a1dc9))
@myparcel-bot
Copy link
Contributor

myparcel-bot bot commented Apr 16, 2024

🎉 This PR is included in version @myparcel/delivery-options-v6.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants