Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix contract carrier behavior when using non-default package type #230

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

EdieLemoine
Copy link
Contributor

@EdieLemoine EdieLemoine commented Jul 2, 2024

INT-566

@EdieLemoine EdieLemoine requested a review from a team as a code owner July 2, 2024 15:10
Copy link

netlify bot commented Jul 2, 2024

Deploy Preview for myparcel-delivery-options ready!

Name Link
🔨 Latest commit 3a56fa8
🔍 Latest deploy log https://app.netlify.com/sites/myparcel-delivery-options/deploys/66868c0beef5b40008602273
😎 Deploy Preview https://deploy-preview-230--myparcel-delivery-options.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jul 2, 2024

Bundle Report

Changes will decrease total bundle size by 33.72kB ⬇️

Bundle name Size Change
@myparcel/delivery-options-MyParcelDeliveryOptionsLib 114.35kB 33.72kB ⬇️

@myparcel-bot myparcel-bot bot force-pushed the fix/package-type-correct-carrier branch from 466c58d to 276cff3 Compare July 2, 2024 15:36
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.54%. Comparing base (0261978) to head (276cff3).

Current head 276cff3 differs from pull request most recent head f4cb96f

Please upload reports for the commit f4cb96f to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #230      +/-   ##
==========================================
- Coverage   80.64%   80.54%   -0.10%     
==========================================
  Files         351      351              
  Lines       11199    11199              
  Branches      611      600      -11     
==========================================
- Hits         9031     9020      -11     
  Misses       1613     1613              
- Partials      555      566      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@myparcel-bot myparcel-bot bot force-pushed the fix/package-type-correct-carrier branch from 276cff3 to f4cb96f Compare July 2, 2024 15:38
@myparcel-bot myparcel-bot bot force-pushed the fix/package-type-correct-carrier branch 2 times, most recently from 8201d4e to 58d1dc2 Compare July 3, 2024 10:12
@myparcel-bot myparcel-bot bot added the approved (Auto) label Jul 3, 2024
@myparcel-bot myparcel-bot bot force-pushed the fix/package-type-correct-carrier branch from 58d1dc2 to 0119ebe Compare July 3, 2024 18:06
@myparcel-bot myparcel-bot bot force-pushed the fix/package-type-correct-carrier branch from 0119ebe to 3a56fa8 Compare July 4, 2024 11:48
@EdieLemoine EdieLemoine added this pull request to the merge queue Jul 4, 2024
Merged via the queue into main with commit 55980b9 Jul 4, 2024
13 checks passed
@EdieLemoine EdieLemoine deleted the fix/package-type-correct-carrier branch July 4, 2024 12:53
myparcel-bot bot added a commit that referenced this pull request Jul 4, 2024
## [@myparcel/delivery-options-v6.1.7](v6.1.6...v6.1.7) (2024-07-04)

### 🐛 Bug Fixes

* fix contract carrier behavior when using non-default package type ([#230](#230)) ([55980b9](55980b9))
@myparcel-bot
Copy link
Contributor

myparcel-bot bot commented Jul 4, 2024

🎉 This PR is included in version @myparcel/delivery-options-v6.1.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@myparcel-bot myparcel-bot bot added the released label Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants