Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix capabilities for carriers on be platform #231

Merged
merged 4 commits into from
Jul 3, 2024

Conversation

EdieLemoine
Copy link
Contributor

@EdieLemoine EdieLemoine commented Jul 2, 2024

  • remove only recipient from bpost
  • add only recipient to postnl
  • enables "fake delivery" for bpost and postnl. (This allows simple delivery options to all countries not in the deliveryCountries list.)

@EdieLemoine EdieLemoine requested a review from a team as a code owner July 2, 2024 15:34
Copy link

netlify bot commented Jul 2, 2024

Deploy Preview for myparcel-delivery-options ready!

Name Link
🔨 Latest commit f3e0863
🔍 Latest deploy log https://app.netlify.com/sites/myparcel-delivery-options/deploys/6684237f7d9436000893a278
😎 Deploy Preview https://deploy-preview-231--myparcel-delivery-options.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@EdieLemoine EdieLemoine changed the title fix/fix shipment options be fix: correct shipment options for carriers on be platform Jul 2, 2024
Copy link

codecov bot commented Jul 2, 2024

Bundle Report

Changes will increase total bundle size by 44 bytes ⬆️

Bundle name Size Change
@myparcel/delivery-options-MyParcelDeliveryOptionsLib 114.36kB 44 bytes ⬆️

@EdieLemoine EdieLemoine force-pushed the fix/fix-shipment-options-be branch from 79be735 to 9ae0651 Compare July 2, 2024 15:36
@myparcel-bot myparcel-bot bot force-pushed the fix/fix-shipment-options-be branch from 6c7215f to e4494bc Compare July 2, 2024 15:38
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.64%. Comparing base (0261978) to head (e4494bc).

Current head e4494bc differs from pull request most recent head 0ccc05e

Please upload reports for the commit 0ccc05e to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #231   +/-   ##
=======================================
  Coverage   80.64%   80.64%           
=======================================
  Files         351      351           
  Lines       11199    11199           
  Branches      611      611           
=======================================
  Hits         9031     9031           
  Misses       1613     1613           
  Partials      555      555           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EdieLemoine EdieLemoine changed the title fix: correct shipment options for carriers on be platform fix: fix capabilities for carriers on be platform Jul 2, 2024
@myparcel-bot myparcel-bot bot added the approved (Auto) label Jul 3, 2024
@EdieLemoine EdieLemoine added this pull request to the merge queue Jul 3, 2024
Merged via the queue into main with commit c93d992 Jul 3, 2024
15 checks passed
@EdieLemoine EdieLemoine deleted the fix/fix-shipment-options-be branch July 3, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved (Auto)
Development

Successfully merging this pull request may close these issues.

3 participants