Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pickup): support dragging map to load more locations #232

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

EdieLemoine
Copy link
Contributor

@EdieLemoine EdieLemoine commented Jul 4, 2024

Note: only supported for PostNL

INT-547

@EdieLemoine EdieLemoine requested a review from a team as a code owner July 4, 2024 11:13
Copy link

netlify bot commented Jul 4, 2024

Deploy Preview for myparcel-delivery-options ready!

Name Link
🔨 Latest commit fde981e
🔍 Latest deploy log https://app.netlify.com/sites/myparcel-delivery-options/deploys/6697a73a4e54fa00085091a1
😎 Deploy Preview https://deploy-preview-232--myparcel-delivery-options.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jul 4, 2024

Bundle Report

Changes will increase total bundle size by 6.08kB ⬆️

Bundle name Size Change
@myparcel/delivery-options-MyParcelDeliveryOptionsLib-esm 151.63kB 3.62kB ⬆️
@myparcel/delivery-options-MyParcelDeliveryOptionsLib-esm-MyParcelDeliveryOptionsLib-umd 116.78kB 2.46kB ⬆️

@myparcel-bot myparcel-bot bot force-pushed the feat/drag-pickup-map branch 2 times, most recently from 60e42ec to 8ecef1a Compare July 4, 2024 12:55
@myparcel-bot myparcel-bot bot force-pushed the feat/drag-pickup-map branch 2 times, most recently from 89c6ae3 to f4ab1eb Compare July 10, 2024 09:19
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 58.23755% with 218 lines in your changes missing coverage. Please review.

Project coverage is 79.79%. Comparing base (9de191c) to head (4c57546).

Files Patch % Lines
...y-options/src/composables/usePickupLocationsMap.ts 16.94% 147 Missing ⚠️
...ions/src/composables/useResolvedPickupLocations.ts 73.45% 18 Missing and 12 partials ⚠️
...mposables/sdk/usePickupLocationsByLatLngRequest.ts 24.13% 22 Missing ⚠️
...livery-options/src/utils/createLatLngParameters.ts 38.88% 6 Missing and 5 partials ⚠️
libs/shared/src/utils/getAllConfigOptions.ts 0.00% 5 Missing ⚠️
...pps/delivery-options/src/stores/useAddressStore.ts 80.00% 0 Missing and 1 partial ⚠️
...ns/src/utils/createGetDeliveryOptionsParameters.ts 83.33% 0 Missing and 1 partial ⚠️
...shared/src/data/getDefaultDeliveryOptionsConfig.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #232      +/-   ##
==========================================
- Coverage   80.64%   79.79%   -0.86%     
==========================================
  Files         351      355       +4     
  Lines       11203    11616     +413     
  Branches      611      653      +42     
==========================================
+ Hits         9035     9269     +234     
- Misses       1613     1803     +190     
+ Partials      555      544      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@joerivanveen joerivanveen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Just checking, zijn deze todo: fix leaflet type errors voor later of wilde je die in deze PR fixen?
  • Ik verwacht de build optimalisaties (.yml files) in een andere PR, of hoort dat hierbij?
  • Codecov klaagt over regels die niet covered by tests zijn, het lijkt zo nu en dan wel te gaan om werkelijke functionaliteit. Is dat geen probleem voor deze repo?

@EdieLemoine EdieLemoine force-pushed the feat/drag-pickup-map branch 2 times, most recently from d5a09c1 to 4c57546 Compare July 11, 2024 08:33
@myparcel-bot myparcel-bot bot force-pushed the feat/drag-pickup-map branch from 4c57546 to fd3b8fe Compare July 11, 2024 09:39
@myparcel-bot myparcel-bot bot added the approved (Auto) label Jul 16, 2024
@EdieLemoine EdieLemoine force-pushed the feat/drag-pickup-map branch 2 times, most recently from 326c020 to 50f0f97 Compare July 17, 2024 11:04
@myparcel-bot myparcel-bot bot force-pushed the feat/drag-pickup-map branch from 50f0f97 to fde981e Compare July 17, 2024 11:12
@EdieLemoine EdieLemoine added this pull request to the merge queue Jul 18, 2024
Merged via the queue into main with commit 8a1fecc Jul 18, 2024
12 of 13 checks passed
@EdieLemoine EdieLemoine deleted the feat/drag-pickup-map branch July 18, 2024 10:07
myparcel-bot bot added a commit that referenced this pull request Aug 14, 2024
## [@myparcel/delivery-options-v6.2.0](v6.1.7...v6.2.0) (2024-08-14)

### ✨ New Features

* **pickup:** support dragging map to load more locations ([#232](#232)) ([8a1fecc](8a1fecc))
@myparcel-bot
Copy link
Contributor

myparcel-bot bot commented Aug 14, 2024

🎉 This issue has been resolved in version @myparcel/delivery-options-v6.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants