fix(pickup): fix map not mounting again after having been unmounted #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for myparcel-delivery-options ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle ReportChanges will increase total bundle size by 171 bytes (0.06%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
EdieLemoine
approved these changes
Sep 9, 2024
FlorianSDV
approved these changes
Sep 9, 2024
myparcel-bot
bot
force-pushed
the
fix/INT-641-fix-map-not-working-after-unmounting
branch
from
4bc4edb to
caa5b5d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #239 +/- ##
==========================================
+ Coverage 74.36% 74.47% +0.10%
==========================================
Files 341 341
Lines 7326 7330 +4
Branches 605 605
==========================================
+ Hits 5448 5459 +11
+ Misses 1281 1274 -7
Partials 597 597 ☔ View full report in Codecov by Sentry. |
myparcel-bot
bot
force-pushed
the
fix/INT-641-fix-map-not-working-after-unmounting
branch
from
caa5b5d to
d3a51b1
Compare
myparcel-bot
bot
force-pushed
the
fix/INT-641-fix-map-not-working-after-unmounting
branch
from
d3a51b1 to
10d4925
Compare
FreekVR
force-pushed
the
fix/INT-641-fix-map-not-working-after-unmounting
branch
from
10d4925 to
0fb40ca
Compare
Fixes an issue where the map would not work again after removal. Updates the `usePickupLocationsMap`-composable to use a global state where possible and not use memoization to achieve the same. Additionally fixes an issue where the map could be panned before being fully loaded. Fixes: INT-641
myparcel-bot
bot
force-pushed
the
fix/INT-641-fix-map-not-working-after-unmounting
branch
from
0fb40ca to
a41b9ba
Compare
RichardPerdaan
deleted the
fix/INT-641-fix-map-not-working-after-unmounting
branch
myparcel-bot bot
added a commit
that referenced
this pull request
Sep 19, 2024
## [@myparcel/delivery-options-v6.2.3](v6.2.2...v6.2.3) (2024-09-19) ### 🐛 Bug Fixes * **pickup:** fix map not mounting again after having been unmounted ([#239](#239)) ([e810b8e](e810b8e))
|
🎉 This issue has been resolved in version @myparcel/delivery-options-v6.2.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the map would not work again after removal.
Updates the
usePickupLocationsMap-composable to use a global state where possible and not use memoization to achieve the same.Additionally fixes an issue where the map could be panned before being fully loaded.
Fixes: INT-641