Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(delivery-schedule): correct weekday mapping for cut-off times #252

Merged
merged 3 commits into from
Oct 10, 2024
Merged

fix(delivery-schedule): correct weekday mapping for cut-off times #252

merged 3 commits into from
Oct 10, 2024

Conversation

MPClerise
Copy link
Contributor

INT-502

fix(delivery-schedule): correct weekday mapping for cut-off times
b605300 
               Replaced manual date setting with  from date-fns to ensure weekdays map correctly, respecting the  option.

               Old:
               - Used a base date and manually set the day.

               New:
               - Utilizes  from date-fns, aligning weekday logic with locale settings for more reliable mapping.

               INT-502
@MPClerise MPClerise requested a review from a team as a code owner October 8, 2024 07:40
@netlify Netlify
Copy link

netlify bot commented Oct 8, 2024 •
edited
Loading

✅ Deploy Preview for myparcel-delivery-options ready!

Name Link
🔨 Latest commit 53f5f69
🔍 Latest deploy log https://app.netlify.com/sites/myparcel-delivery-options/deploys/67065102de18bf0008787317
😎 Deploy Preview https://deploy-preview-252--myparcel-delivery-options.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov Codecov
Copy link

codecov bot commented Oct 8, 2024

Bundle Report

Bundle size has no change ✅

joerivanveen
joerivanveen reviewed Oct 8, 2024
View reviewed changes
Copy link
Contributor

@joerivanveen joerivanveen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imho this change should be confirmed in a test / tests, so we don’t break it in the future.

@myparcel-bot myparcel-bot bot added the approved (Auto) label Oct 9, 2024
@MPClerise MPClerise added this pull request to the merge queue Oct 10, 2024
github-merge-queue bot pushed a commit that referenced this pull request Oct 10, 2024
@MPClerise
fix(delivery-schedule): correct weekday mapping for cut-off times (#252)
62fd354 
INT-502

---------

Co-authored-by: Clerise Swart <[email protected]>
Merged via the queue into main with commit 03d73e0 Oct 10, 2024
14 checks passed
@MPClerise MPClerise deleted the fix/cut-off-time branch October 10, 2024 14:19
EdieLemoine pushed a commit that referenced this pull request Oct 10, 2024
@MPClerise @EdieLemoine
fix: correct weekday mapping for cut-off times (#252)
d8f4b95 
INT-502

---------
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joerivanveen joerivanveen joerivanveen left review comments

@GravendeelJochem GravendeelJochem GravendeelJochem approved these changes

@FlorianSDV FlorianSDV FlorianSDV approved these changes

Assignees
No one assigned
Labels
approved (Auto)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MPClerise @joerivanveen @FlorianSDV @GravendeelJochem