fix(app-builder): replace composer require with update

myparcelnl · Nov 20, 2024 · f2fd451 · f2fd451
1 parent 6a5cf1e
commit f2fd451
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/apps/app-builder/src/commands/upgrade/composer/upgradeComposerPackage.ts b/apps/app-builder/src/commands/upgrade/composer/upgradeComposerPackage.ts
@@ -12,7 +12,7 @@ export const upgradeComposerPackage = async (context: PdkBuilderUpgradeContext):
   const oldVersions = await getComposerPackageVersion(context);
 
   if (!args.dryRun) {
-    await executeCommand(context, config.composerCommand, ['require', packageName]);
+    await executeCommand(context, config.composerCommand, ['update', packageName]);
   }
 
   return {

diff --git a/apps/app-builder/src/commands/upgrade/upgrade.spec.ts b/apps/app-builder/src/commands/upgrade/upgrade.spec.ts
@@ -11,13 +11,13 @@ import {type UpgradeCommandArgs} from './upgrade.types';
 
 describe('command: upgrade', () => {
   const composerShowSpy = vi.fn(() => '{"name":"myparcelnl/pdk","source":{"url":""},"versions":["1.0.0"]}');
-  const composerRequireSpy = vi.fn(() => '');
+  const composerUpdateSpy = vi.fn(() => '');
   const yarnInfoSpy = vi.fn(() => '{}');
   const yarnUpgradeSpy = vi.fn(() => '');
 
   const spyMap = {
     'composer show': composerShowSpy,
-    'composer require': composerRequireSpy,
+    'composer update': composerUpdateSpy,
     'yarn info': yarnInfoSpy,
     'yarn up': yarnUpgradeSpy,
   };
@@ -63,7 +63,7 @@ describe('command: upgrade', () => {
     await upgrade(context);
 
     expect(composerShowSpy).toHaveBeenCalledWith('composer', ['show', '--format=json', MYPARCEL_PDK_PACKAGIST_NAME]);
-    expect(composerRequireSpy).toHaveBeenCalledWith('composer', ['require', MYPARCEL_PDK_PACKAGIST_NAME]);
+    expect(composerUpdateSpy).toHaveBeenCalledWith('composer', ['update', MYPARCEL_PDK_PACKAGIST_NAME]);
 
     expect(yarnInfoSpy).not.toHaveBeenCalled();
     expect(yarnUpgradeSpy).not.toHaveBeenCalled();
@@ -87,7 +87,7 @@ describe('command: upgrade', () => {
 
     expect(yarnInfoSpy).toHaveBeenCalledWith('yarn', ['info', '--all', '--name-only', '--json']);
     expect(yarnUpgradeSpy).toHaveBeenCalledWith('yarn', ['up', '-R', packageName]);
-    expect(composerRequireSpy).not.toHaveBeenCalled();
+    expect(composerUpdateSpy).not.toHaveBeenCalled();
     expect(composerShowSpy).not.toHaveBeenCalled();
   });
 });