Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(admin): add shipping methods input #210

Merged
merged 10 commits into from
Jun 5, 2024

Conversation

EdieLemoine
Copy link
Contributor

@EdieLemoine EdieLemoine commented May 23, 2024

INT-433

@EdieLemoine EdieLemoine changed the title feat/int 433 shipping component feat: add shipping methods input May 23, 2024
@EdieLemoine EdieLemoine changed the title feat: add shipping methods input feat(admin): add shipping methods input May 23, 2024
@myparcel-bot myparcel-bot bot added the approved (Auto) label May 29, 2024
@myparcel-bot myparcel-bot bot force-pushed the feat/int-433-shipping-component branch 4 times, most recently from 61c487f to 02a151d Compare June 5, 2024 14:25
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 80.89330% with 77 lines in your changes missing coverage. Please review.

Project coverage is 66.15%. Comparing base (115e103) to head (969b9b4).

Files Patch % Lines
apps/admin/src/composables/useLoadMore.ts 36.95% 29 Missing ⚠️
apps/admin/src/composables/useElementOptions.ts 69.76% 4 Missing and 9 partials ⚠️
.../src/composables/useShippingMethodsInputContext.ts 90.35% 0 Missing and 11 partials ⚠️
...ult/src/components/DefaultShippingMethodsInput.vue 88.00% 2 Missing and 7 partials ⚠️
...ests/src/components/runShippingMethodsInputTest.ts 63.63% 8 Missing ⚠️
...c/components/common/DeliveryOptionsPackageType.vue 0.00% 3 Missing ⚠️
...min-preset-default/src/components/DefaultTable.vue 84.61% 0 Missing and 2 partials ⚠️
...dmin/src/composables/useInputWithOptionsContext.ts 83.33% 1 Missing ⚠️
apps/admin/src/types/component-bindings.types.ts 92.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #210      +/-   ##
==========================================
+ Coverage   65.65%   66.15%   +0.49%     
==========================================
  Files         680      686       +6     
  Lines       18396    18788     +392     
  Branches      673      709      +36     
==========================================
+ Hits        12078    12429     +351     
- Misses       5654     5666      +12     
- Partials      664      693      +29     
Flag Coverage Δ
unit 66.15% <80.89%> (+0.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EdieLemoine EdieLemoine added this pull request to the merge queue Jun 5, 2024
@EdieLemoine EdieLemoine removed this pull request from the merge queue due to a manual request Jun 5, 2024
@EdieLemoine EdieLemoine enabled auto-merge June 5, 2024 15:54
@EdieLemoine EdieLemoine force-pushed the feat/int-433-shipping-component branch from 8c5522d to 7c335f8 Compare June 5, 2024 15:54
@EdieLemoine EdieLemoine added this pull request to the merge queue Jun 5, 2024
Merged via the queue into main with commit 79758ad Jun 5, 2024
7 of 8 checks passed
@EdieLemoine EdieLemoine deleted the feat/int-433-shipping-component branch June 5, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved (Auto)
Development

Successfully merging this pull request may close these issues.

3 participants