Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(checkout): correctly switch package type based on shipping methods #212

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

EdieLemoine
Copy link
Contributor

@EdieLemoine EdieLemoine commented Jun 28, 2024

INT-433

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 65.57377% with 42 lines in your changes missing coverage. Please review.

Project coverage is 66.13%. Comparing base (9940421) to head (109bd99).

Files Patch % Lines
...tions/src/defaults/defaultUpdateDeliveryOptions.ts 27.77% 13 Missing ⚠️
...checkout-common/src/defaults/defaultGetFormData.ts 36.36% 7 Missing ⚠️
...kout-common/src/utils/getEnabledShippingMethods.ts 33.33% 6 Missing ⚠️
...t-common/src/defaults/defaultHasDeliveryOptions.ts 50.00% 4 Missing ⚠️
...-delivery-options/src/utils/getResolvedSettings.ts 20.00% 4 Missing ⚠️
...very-options/src/defaults/defaultGetPackageType.ts 86.36% 0 Missing and 3 partials ⚠️
.../checkout-common/src/defaults/defaultFormChange.ts 88.88% 0 Missing and 1 partial ⚠️
...ckout-common/src/defaults/defaultGetAddressType.ts 75.00% 0 Missing and 1 partial ⚠️
...heckout-common/src/listeners/updateCheckoutForm.ts 66.66% 0 Missing and 1 partial ⚠️
libs/checkout-common/src/types/checkout.types.ts 83.33% 0 Missing and 1 partial ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #212      +/-   ##
==========================================
+ Coverage   66.10%   66.13%   +0.03%     
==========================================
  Files         686      695       +9     
  Lines       18809    18913     +104     
  Branches      711      719       +8     
==========================================
+ Hits        12433    12508      +75     
- Misses       5685     5716      +31     
+ Partials      691      689       -2     
Flag Coverage Δ
unit 66.13% <65.57%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@myparcel-bot myparcel-bot bot force-pushed the fix/switch-package-type-in-checkout branch from 4e4fa18 to 7e91e95 Compare June 28, 2024 14:34
@EdieLemoine EdieLemoine force-pushed the fix/switch-package-type-in-checkout branch from 7e91e95 to 8f3525c Compare June 28, 2024 15:07
@myparcel-bot myparcel-bot bot force-pushed the fix/switch-package-type-in-checkout branch from 8f3525c to 109bd99 Compare June 29, 2024 18:04
@myparcel-bot myparcel-bot bot added the approved (Auto) label Jul 2, 2024
@EdieLemoine EdieLemoine added this pull request to the merge queue Jul 2, 2024
Merged via the queue into main with commit f25ebed Jul 2, 2024
8 of 10 checks passed
@EdieLemoine EdieLemoine deleted the fix/switch-package-type-in-checkout branch July 2, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved (Auto)
Development

Successfully merging this pull request may close these issues.

3 participants