Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(checkout): improve shipping logic and expose default methods #216

Merged
merged 3 commits into from
Sep 26, 2024

Conversation

EdieLemoine
Copy link
Contributor

@EdieLemoine EdieLemoine commented Sep 4, 2024

INT-622

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 75.94937% with 19 lines in your changes missing coverage. Please review.

Project coverage is 66.69%. Comparing base (e2252f9) to head (182f88d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...delivery-options/src/utils/fetchCheckoutContext.ts 30.76% 9 Missing ⚠️
...ions/src/utils/getPackageTypeFromShippingMethod.ts 77.77% 0 Missing and 4 partials ⚠️
...eckout-delivery-options/src/utils/updateContext.ts 50.00% 2 Missing ⚠️
libs/checkout-common/src/types/checkout.types.ts 50.00% 0 Missing and 1 partial ⚠️
libs/checkout-common/src/types/store.types.ts 66.66% 0 Missing and 1 partial ⚠️
...bs/checkout-common/src/utils/getFrontendContext.ts 80.00% 0 Missing and 1 partial ⚠️
libs/checkout-common/src/utils/useSettings.ts 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #216      +/-   ##
==========================================
+ Coverage   66.66%   66.69%   +0.03%     
==========================================
  Files         687      689       +2     
  Lines       19101    19158      +57     
  Branches      805      810       +5     
==========================================
+ Hits        12733    12778      +45     
- Misses       5711     5720       +9     
- Partials      657      660       +3     
Flag Coverage Δ
unit 66.69% <75.94%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@myparcel-bot myparcel-bot bot force-pushed the feat/improve-shipping-logic branch from d60d2a0 to 70eb790 Compare September 5, 2024 12:13
@FlorianSDV FlorianSDV force-pushed the feat/improve-shipping-logic branch from 70eb790 to 6fa038d Compare September 6, 2024 07:33
@myparcel-bot myparcel-bot bot added the approved (Auto) label Sep 10, 2024
@myparcel-bot myparcel-bot bot force-pushed the feat/improve-shipping-logic branch 2 times, most recently from c8d1abe to fa1357a Compare September 12, 2024 18:05
@myparcel-bot myparcel-bot bot force-pushed the feat/improve-shipping-logic branch from fa1357a to ba5605a Compare September 19, 2024 11:01
@myparcel-bot myparcel-bot bot force-pushed the feat/improve-shipping-logic branch from ba5605a to 182f88d Compare September 20, 2024 18:05
@RichardPerdaan RichardPerdaan added this pull request to the merge queue Sep 26, 2024
Merged via the queue into main with commit e860ba2 Sep 26, 2024
7 of 8 checks passed
@RichardPerdaan RichardPerdaan deleted the feat/improve-shipping-logic branch September 26, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved (Auto)
Development

Successfully merging this pull request may close these issues.

4 participants