Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(order): add helpful text when using postnl age check #222

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

EdieLemoine
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 65.15152% with 23 lines in your changes missing coverage. Please review.

Project coverage is 67.50%. Comparing base (5fa26b0) to head (0329e95).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...dmin/src/forms/helpers/setPostNlAgeCheckSubtext.ts 52.94% 8 Missing ⚠️
apps/admin/src/forms/helpers/hasPostNlAgeCheck.ts 63.63% 4 Missing ⚠️
apps/admin/src/forms/helpers/createLabel.ts 33.33% 0 Missing and 2 partials ⚠️
...orms/shipmentOptions/fields/createAgeCheckField.ts 33.33% 2 Missing ⚠️
...forms/shipmentOptions/fields/createCarrierField.ts 33.33% 2 Missing ⚠️
...admin/src/forms/helpers/addBulkEditNotification.ts 66.66% 1 Missing ⚠️
apps/admin/src/forms/helpers/getFieldLabel.ts 83.33% 1 Missing ⚠️
...shipmentOptions/fields/createOnlyRecipientField.ts 50.00% 1 Missing ⚠️
...hipmentOptions/fields/createShipmentOptionField.ts 66.66% 1 Missing ⚠️
...rms/shipmentOptions/fields/createSignatureField.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #222      +/-   ##
==========================================
- Coverage   67.50%   67.50%   -0.01%     
==========================================
  Files         688      692       +4     
  Lines       19172    19226      +54     
  Branches      809      812       +3     
==========================================
+ Hits        12942    12978      +36     
- Misses       5577     5594      +17     
- Partials      653      654       +1     
Flag Coverage Δ
unit 67.50% <65.15%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@myparcel-bot myparcel-bot bot force-pushed the feat/help-text-postnl-age-check branch from 3ae498f to f9a5fdd Compare October 4, 2024 10:31
@myparcel-bot myparcel-bot bot force-pushed the feat/help-text-postnl-age-check branch from f9a5fdd to 0329e95 Compare October 5, 2024 18:06
Copy link
Contributor

@joerivanveen joerivanveen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ik vind het er goed uitzien en een nuttige toevoeging, maar moet er niet wat functionaliteit in tests vastgelegd worden? (Codecov mekkert.)

@EdieLemoine EdieLemoine enabled auto-merge October 9, 2024 14:26
@EdieLemoine
Copy link
Contributor Author

@joerivanveen eens, maar niet in deze story, heeft haast en is inmiddels al getest

@EdieLemoine EdieLemoine disabled auto-merge October 9, 2024 14:26
@EdieLemoine EdieLemoine merged commit f05022d into main Oct 9, 2024
7 of 8 checks passed
@EdieLemoine EdieLemoine deleted the feat/help-text-postnl-age-check branch October 9, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants