Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creation of dynamic property MyParcelNL\Magento\Model\Settings\AccountSettings::$shop is deprecated #817

Closed
jdereus87 opened this issue Feb 9, 2024 · 2 comments · Fixed by #818
Closed

Creation of dynamic property MyParcelNL\Magento\Model\Settings\AccountSettings::$shop is deprecated #817

jdereus87 opened this issue Feb 9, 2024 · 2 comments · Fixed by #818
Labels
bug Something isn't working released

Comments

@jdereus87
Copy link

Plugin version

4.11.1

Magento version

2.4.6-p3

PHP version

8.2

What went wrong?

Different parts on the modules crash because of: Creation of dynamic property MyParcelNL\Magento\Model\Settings\AccountSettings::$shop is deprecated

This is due PHP 8.2 deprecation of dynamic properties

Reproduction steps

  1. Navigate to backend -> MyParcel
  2. Click on the PostNL section. Its gives an error output.

Relevant log output

No response

Additional context

No response
@jdereus87 jdereus87 added the bug Something isn't working label Feb 9, 2024
@jdereus87
Copy link
Author

This also applies for other properties set in the class

@Aquive Aquive mentioned this issue Feb 9, 2024
Merged
@MyParcelBot
Copy link

🎉 This issue has been resolved in version 4.12.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fix php 8.2 deprecation error Aquive/myparcel
3 participants
@jdereus87 @MyParcelBot @wthijmen