Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix php 8.2 deprecation error #818

Merged
merged 2 commits into from
Feb 21, 2024
Merged

fix: fix php 8.2 deprecation error #818

merged 2 commits into from
Feb 21, 2024

Conversation

Aquive
Copy link
Contributor

@Aquive Aquive commented Feb 9, 2024 •
edited by EdieLemoine
Loading

Resolves #817

@Aquive Aquive requested a review from a team as a code owner February 9, 2024 14:24
@Mark-Ernst Mark-Ernst changed the base branch from main to develop February 9, 2024 14:48
Mark-Ernst
Mark-Ernst suggested changes Feb 9, 2024
View reviewed changes
Model/Settings/AccountSettings.php Outdated Show resolved Hide resolved
@EdieLemoine EdieLemoine changed the title Fix: add class properties fix: fix php 8.2 deprecation error Feb 9, 2024
@Mark-Ernst Mark-Ernst merged commit 793f7ef into myparcelnl:develop Feb 21, 2024
1 check passed
MyParcelBot pushed a commit that referenced this pull request Feb 21, 2024
@semantic-release-bot
chore(release): 4.12.1 [skip ci]
9806326 
## [4.12.1](v4.12.0...v4.12.1) (2024-02-21)

### 🐛 Bug Fixes

* fix php 8.2 deprecation error ([#818](#818)) ([793f7ef](793f7ef))
* use both address lines for street name ([#819](#819)) ([2053b08](2053b08))
@MyParcelBot
Copy link

🎉 This PR is included in version 4.12.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wthijmen wthijmen wthijmen approved these changes

@Mark-Ernst Mark-Ernst Mark-Ernst approved these changes

Assignees
No one assigned
Labels
released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Creation of dynamic property MyParcelNL\Magento\Model\Settings\AccountSettings::$shop is deprecated
4 participants
@Aquive @MyParcelBot @Mark-Ernst @wthijmen