Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only set country if currentCountry has value #794

Merged
merged 2 commits into from
Dec 1, 2023
Merged

fix: only set country if currentCountry has value #794

merged 2 commits into from
Dec 1, 2023

Conversation

wthijmen
Copy link
Contributor

Resolves #789

@wthijmen wthijmen requested a review from a team as a code owner November 24, 2023 15:33
EdieLemoine
EdieLemoine suggested changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@EdieLemoine EdieLemoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dit is geen refactor

Model/Sales/Package.php Outdated Show resolved Hide resolved
@wthijmen wthijmen changed the title refactor: only set country if not null fix: only set country is currentCountry has value Nov 29, 2023
@wthijmen wthijmen changed the title fix: only set country is currentCountry has value fix: only set country if currentCountry has value Nov 29, 2023
@wthijmen wthijmen requested a review from EdieLemoine November 29, 2023 14:06
@EdieLemoine EdieLemoine merged commit e86d3fe into develop Dec 1, 2023
1 check passed
@EdieLemoine EdieLemoine deleted the refactor-set-country-if-not-null branch December 1, 2023 16:05
MyParcelBot pushed a commit that referenced this pull request Feb 1, 2024
@semantic-release-bot
chore(release): 4.12.0 [skip ci]
ef7e89b 
## [4.12.0](v4.11.1...v4.12.0) (2024-02-01)

### 🐛 Bug Fixes

* allow observer to use transport object ([#805](#805)) ([e64a687](e64a687))
* **checkout:** prevent delivery options from disappearing ([#811](#811)) ([1f153dc](1f153dc))
* **checkout:** prevent missing street from blocking delivery options ([#813](#813)) ([169e8be](169e8be))
* fix large format issue ([#798](#798)) ([dd98a32](dd98a32))
* fix php deprecation error ([#793](#793)) ([5222a77](5222a77))
* **fulfilment:** export phonenumber and weight ([#810](#810)) ([d2b2a85](d2b2a85))
* **fulfilment:** set weight on customs item rather than throw error ([#814](#814)) ([2eadcbc](2eadcbc))
* implement regression feedback ([#806](#806)) ([0b3b1f0](0b3b1f0))
* only set country if currentCountry has value ([#794](#794)) ([e86d3fe](e86d3fe))

### ✨ New Features

* add carrier dpd ([#786](#786)) ([e87fe71](e87fe71))
* add carrier ups ([#787](#787)) ([c6aff00](c6aff00))
* add digital stamp weight range ([#801](#801)) ([696b771](696b771))
* add state to consignment ([#815](#815)) ([8c3e208](8c3e208))
@MyParcelBot
Copy link

🎉 This PR is included in version 4.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joerivanveen joerivanveen joerivanveen approved these changes

@Mark-Ernst Mark-Ernst Mark-Ernst approved these changes

@EdieLemoine EdieLemoine EdieLemoine approved these changes

Assignees
No one assigned
Labels
released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wthijmen @MyParcelBot @EdieLemoine @Mark-Ernst @joerivanveen