refactor: prevent unnecessary early return

myparcelnl · Dec 17, 2024 · 5f869e2 · 5f869e2
1 parent 494f7de
commit 5f869e2
Showing 1 changed file with 6 additions and 8 deletions.
diff --git a/src/App/Webhook/Hook/ShipmentStatusChangeWebhook.php b/src/App/Webhook/Hook/ShipmentStatusChangeWebhook.php
@@ -25,15 +25,13 @@ public function handle(Request $request): void
         // translate order_id (which is api identifier / uuid) to local order id for db
         $order = Pdk::get(PdkOrderRepositoryInterface::class)->getByApiIdentifier($content['order_id']);
 
-        if (! $order) {
-            return;
+        if ($order) {
+            Actions::execute(PdkBackendActions::UPDATE_SHIPMENTS, [
+                'orderIds'                      => [$order->getExternalIdentifier()],
+                'shipmentIds'                   => [$content['shipment_id']],
+                'linkFirstShipmentToFirstOrder' => true,
+            ]);
         }
-
-        Actions::execute(PdkBackendActions::UPDATE_SHIPMENTS, [
-            'orderIds'                      => [$order->getExternalIdentifier()],
-            'shipmentIds'                   => [$content['shipment_id']],
-            'linkFirstShipmentToFirstOrder' => true,
-        ]);
     }