Skip to content

Commit

Permalink
fix: feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
Mark-Ernst authored and myparcel-bot[bot] committed Oct 25, 2023
1 parent 82082a1 commit 6f8d6ef
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
6 changes: 6 additions & 0 deletions config/pdk-settings.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
use MyParcelNL\Pdk\Facade\Platform;
use MyParcelNL\Pdk\Settings\Model\CarrierSettings;
use MyParcelNL\Pdk\Settings\Model\CustomsSettings;
use MyParcelNL\Pdk\Settings\Model\OrderSettings;
use MyParcelNL\Pdk\Settings\SettingsManager;
use MyParcelNL\Pdk\Shipment\Model\DeliveryOptions;
use MyParcelNL\Pdk\Shipment\Model\DropOffDay;
Expand Down Expand Up @@ -80,6 +81,11 @@
CarrierSettings::SHOW_DELIVERY_DAY => true,
],
],
OrderSettings::ID => [
SettingsManager::KEY_ALL => [
OrderSettings::STATUS_ON_LABEL_CREATE => -1,
],
],
];
}),

Expand Down
2 changes: 1 addition & 1 deletion src/App/Action/Backend/Order/UpdateOrderStatusAction.php
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public function handle(Request $request): Response

$status = SettingsFacade::get($settingName, OrderSettings::ID);

if (Settings::OPTION_NONE === (int) $status || null === $status) {
if (Settings::OPTION_NONE === (int) $status) {
return $this->getResponse();
}

Expand Down

0 comments on commit 6f8d6ef

Please sign in to comment.