Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename order number to reference identifier #212

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

Mark-Ernst
Copy link
Contributor

@Mark-Ernst Mark-Ernst commented Oct 9, 2023

No description provided.

@Mark-Ernst Mark-Ernst requested a review from a team as a code owner October 9, 2023 07:48
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #212 (dc753e3) into main (0106cd7) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main     #212   +/-   ##
=========================================
  Coverage     94.23%   94.23%           
  Complexity     1550     1550           
=========================================
  Files           300      300           
  Lines          5311     5311           
=========================================
  Hits           5005     5005           
  Misses          306      306           
Files Coverage Δ
.../Calculator/General/LabelDescriptionCalculator.php 100.00% <100.00%> (ø)
src/App/Order/Model/PdkOrder.php 100.00% <100.00%> (ø)
src/Fulfilment/Model/Order.php 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@EdieLemoine EdieLemoine changed the title refactor: rename ordernumber to referenceidentifier refactor: rename order number to reference identifier Oct 10, 2023
src/App/Order/Model/PdkOrder.php Outdated Show resolved Hide resolved
@myparcel-bot myparcel-bot bot added the changes requested (Auto) label Oct 10, 2023
@EdieLemoine EdieLemoine added this pull request to the merge queue Oct 10, 2023
@myparcel-bot myparcel-bot bot added approved (Auto) and removed changes requested (Auto) labels Oct 10, 2023
Merged via the queue into main with commit fae32d4 Oct 10, 2023
7 checks passed
@EdieLemoine EdieLemoine deleted the fix/rename-order-number-property branch October 10, 2023 11:50
@MyParcelBot
Copy link

🎉 This PR is included in version 2.27.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants