Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(shipment): include address2 in street #214

Merged
merged 2 commits into from
Oct 13, 2023
Merged

fix(shipment): include address2 in street #214

merged 2 commits into from
Oct 13, 2023

Conversation

Mark-Ernst
Copy link
Contributor

No description provided.

@Mark-Ernst Mark-Ernst requested a review from a team as a code owner October 12, 2023 07:21
@Mark-Ernst Mark-Ernst force-pushed the fix/inlude-address2-in-street branch from 11c9afb to 6c4ee73 Compare October 12, 2023 07:22
@codecov
Copy link

codecov bot commented Oct 12, 2023 •
edited
Loading

Codecov Report

Merging #214 (6d014b6) into main (931485e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main     #214   +/-   ##
=========================================
  Coverage     94.23%   94.23%           
- Complexity     1550     1551    +1     
=========================================
  Files           300      300           
  Lines          5311     5312    +1     
=========================================
+ Hits           5005     5006    +1     
  Misses          306      306
Files Coverage Δ
src/Shipment/Request/PostShipmentsRequest.php 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@EdieLemoine EdieLemoine changed the title fix: include address2 in street fix(shipment): include address2 in street Oct 12, 2023
EdieLemoine
EdieLemoine suggested changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@EdieLemoine EdieLemoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

er zijn allemaal ongerelateerde snapshots aangepast, en ik mis een test die bevestigt dat dit correct in de street komt

src/Shipment/Request/PostShipmentsRequest.php Show resolved Hide resolved
@myparcel-bot myparcel-bot bot added the changes requested (Auto) label Oct 12, 2023
@Mark-Ernst Mark-Ernst force-pushed the fix/inlude-address2-in-street branch from 5fedf1a to 6c4ee73 Compare October 12, 2023 09:30
@Mark-Ernst Mark-Ernst force-pushed the fix/inlude-address2-in-street branch 2 times, most recently from 6c86b3c to a9c35d2 Compare October 12, 2023 12:57
@EdieLemoine EdieLemoine enabled auto-merge October 12, 2023 13:49
@myparcel-bot myparcel-bot bot removed the changes requested (Auto) label Oct 12, 2023
@myparcel-bot myparcel-bot bot force-pushed the fix/inlude-address2-in-street branch from a9c35d2 to e2f0276 Compare October 12, 2023 14:57
@myparcel-bot myparcel-bot bot force-pushed the fix/inlude-address2-in-street branch from e2f0276 to 6d014b6 Compare October 13, 2023 07:36
@EdieLemoine EdieLemoine added this pull request to the merge queue Oct 13, 2023
@myparcel-bot myparcel-bot bot added the approved (Auto) label Oct 13, 2023
Merged via the queue into main with commit 0e434de Oct 13, 2023
7 checks passed
@EdieLemoine EdieLemoine deleted the fix/inlude-address2-in-street branch October 13, 2023 07:49
MyParcelBot pushed a commit that referenced this pull request Oct 13, 2023
@semantic-release-bot
chore(release): 2.28.0 [skip ci]
e7356af 
## [2.28.0](v2.27.0...v2.28.0) (2023-10-13)

### 🐛 Bug Fixes

* **shipment:** include address2 in street ([#214](#214)) ([0e434de](0e434de))

### ✨ New Features

* **order:** allow changing digital stamp weight range ([#215](#215)) ([20a58fa](20a58fa))
@MyParcelBot
Copy link

🎉 This PR is included in version 2.28.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joerivanveen joerivanveen joerivanveen approved these changes

@EdieLemoine EdieLemoine EdieLemoine approved these changes

Assignees

@Mark-Ernst Mark-Ernst

Labels
approved (Auto) released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mark-Ernst @MyParcelBot @EdieLemoine @joerivanveen