Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(returns): prevent validation error on export return #216

Merged
merged 6 commits into from
Oct 20, 2023

Conversation

joerivanveen
Copy link
Contributor

@joerivanveen joerivanveen commented Oct 14, 2023

INT-191

@codecov
Copy link

codecov bot commented Oct 14, 2023

Codecov Report

Merging #216 (108339d) into main (94508ee) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #216      +/-   ##
============================================
+ Coverage     94.31%   94.33%   +0.01%     
- Complexity     1555     1558       +3     
============================================
  Files           301      301              
  Lines          5330     5347      +17     
============================================
+ Hits           5027     5044      +17     
  Misses          303      303              
Files Coverage Δ
...rc/Shipment/Request/PostReturnShipmentsRequest.php 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@joerivanveen joerivanveen marked this pull request as ready for review October 14, 2023 19:54
@joerivanveen joerivanveen requested a review from a team as a code owner October 14, 2023 19:54
@EdieLemoine EdieLemoine changed the title fix: prevent validation error on export return fix(returns): prevent validation error on export return Oct 16, 2023
@joerivanveen joerivanveen force-pushed the fix/prevent-validation-error-on-export-return branch from aa64a53 to c40abbe Compare October 16, 2023 09:06
@myparcel-bot myparcel-bot bot added the approved (Auto) label Oct 16, 2023
Copy link
Contributor

@EdieLemoine EdieLemoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ik mis tests (of gewijzigde snapshots)

@myparcel-bot myparcel-bot bot added changes requested (Auto) and removed approved (Auto) labels Oct 16, 2023
@joerivanveen joerivanveen force-pushed the fix/prevent-validation-error-on-export-return branch from 9330d22 to 03eca05 Compare October 16, 2023 17:27
@myparcel-bot myparcel-bot bot force-pushed the fix/prevent-validation-error-on-export-return branch from dcecea0 to 2ff064e Compare October 19, 2023 12:07
Copy link
Contributor

@EdieLemoine EdieLemoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super nice 🏭😎

@joerivanveen joerivanveen added this pull request to the merge queue Oct 20, 2023
@myparcel-bot myparcel-bot bot added approved (Auto) and removed changes requested (Auto) labels Oct 20, 2023
Merged via the queue into main with commit a046143 Oct 20, 2023
8 checks passed
@joerivanveen joerivanveen deleted the fix/prevent-validation-error-on-export-return branch October 20, 2023 07:05
MyParcelBot pushed a commit that referenced this pull request Oct 20, 2023
## [2.28.1](v2.28.0...v2.28.1) (2023-10-20)

### 🐛 Bug Fixes

* **returns:** prevent validation error on export return ([#216](#216)) ([a046143](a046143))
@MyParcelBot
Copy link

🎉 This PR is included in version 2.28.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants