Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(order): fix error on updating order status if setting is empty #221

Merged
merged 4 commits into from
Oct 26, 2023

Conversation

Mark-Ernst
Copy link
Contributor

@Mark-Ernst Mark-Ernst commented Oct 24, 2023

INT-219

@Mark-Ernst Mark-Ernst requested a review from a team as a code owner October 24, 2023 13:15
Copy link
Contributor

@EdieLemoine EdieLemoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ik mis tests en een scope in je titel. De titel beschrijft ook niet wanneer deze error optreedt

@myparcel-bot myparcel-bot bot added the changes requested (Auto) label Oct 24, 2023
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #221 (245fd21) into main (5f0d5f2) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #221   +/-   ##
=========================================
  Coverage     94.34%   94.34%           
  Complexity     1563     1563           
=========================================
  Files           301      301           
  Lines          5358     5358           
=========================================
  Hits           5055     5055           
  Misses          303      303           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Mark-Ernst Mark-Ernst changed the title fix: fix error when status is null fix(order-status): fix error when label is created Oct 24, 2023
@EdieLemoine EdieLemoine changed the title fix(order-status): fix error when label is created fix(order): fix error on updating order status if setting is empty Oct 24, 2023
@myparcel-bot myparcel-bot bot added the changes requested (Auto) label Oct 24, 2023
@myparcel-bot myparcel-bot bot force-pushed the fix/fix-error-when-status-is-null branch from 45fa030 to 98fa401 Compare October 24, 2023 15:24
@Mark-Ernst Mark-Ernst force-pushed the fix/fix-error-when-status-is-null branch from 98fa401 to 50fe2a0 Compare October 25, 2023 07:42
@myparcel-bot myparcel-bot bot force-pushed the fix/fix-error-when-status-is-null branch from 9acd2c9 to 1920fc7 Compare October 25, 2023 09:59
config/pdk-settings.php Outdated Show resolved Hide resolved
@myparcel-bot myparcel-bot bot force-pushed the fix/fix-error-when-status-is-null branch 2 times, most recently from 11d1314 to 789408b Compare October 25, 2023 13:02
@myparcel-bot myparcel-bot bot force-pushed the fix/fix-error-when-status-is-null branch from 789408b to 245fd21 Compare October 26, 2023 07:27
@EdieLemoine EdieLemoine added this pull request to the merge queue Oct 26, 2023
@myparcel-bot myparcel-bot bot added approved (Auto) and removed changes requested (Auto) labels Oct 26, 2023
Merged via the queue into main with commit b36d55c Oct 26, 2023
8 checks passed
@EdieLemoine EdieLemoine deleted the fix/fix-error-when-status-is-null branch October 26, 2023 08:53
MyParcelBot pushed a commit that referenced this pull request Oct 26, 2023
## [2.28.5](v2.28.4...v2.28.5) (2023-10-26)

### 🐛 Bug Fixes

* **order:** fix error on updating order status if setting is empty ([#221](#221)) ([b36d55c](b36d55c))
* **support:** make toArray act consistently everywhere ([#224](#224)) ([5f0d5f2](5f0d5f2))
@MyParcelBot
Copy link

🎉 This PR is included in version 2.28.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants