Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(caching): use apc only when enabled #239

Merged
merged 3 commits into from
Nov 23, 2023

Conversation

joerivanveen
Copy link
Contributor

@joerivanveen joerivanveen commented Nov 21, 2023

INT-224

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e1e2f72) 95.73% compared to head (5b0f31d) 95.82%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #239      +/-   ##
============================================
+ Coverage     95.73%   95.82%   +0.09%     
  Complexity     1601     1601              
============================================
  Files           307      307              
  Lines          5491     5491              
============================================
+ Hits           5257     5262       +5     
+ Misses          234      229       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joerivanveen joerivanveen marked this pull request as ready for review November 21, 2023 13:17
@joerivanveen joerivanveen requested a review from a team as a code owner November 21, 2023 13:17
@joerivanveen joerivanveen marked this pull request as draft November 21, 2023 13:18
@joerivanveen joerivanveen force-pushed the fix/caching/use-apc-only-when-enabled branch from 4113672 to dc779d5 Compare November 21, 2023 16:41
@joerivanveen joerivanveen marked this pull request as ready for review November 21, 2023 16:41
@myparcel-bot myparcel-bot bot added the approved (Auto) label Nov 23, 2023
@myparcel-bot myparcel-bot bot force-pushed the fix/caching/use-apc-only-when-enabled branch from dc779d5 to 5b0f31d Compare November 23, 2023 08:49
@EdieLemoine EdieLemoine added this pull request to the merge queue Nov 23, 2023
Merged via the queue into main with commit 7b4ebbd Nov 23, 2023
@EdieLemoine EdieLemoine deleted the fix/caching/use-apc-only-when-enabled branch November 23, 2023 10:39
MyParcelBot pushed a commit that referenced this pull request Nov 23, 2023
## [2.31.1](v2.31.0...v2.31.1) (2023-11-23)

### 🐛 Bug Fixes

* **caching:** use apc only when enabled ([#239](#239)) ([7b4ebbd](7b4ebbd))
@MyParcelBot
Copy link

🎉 This PR is included in version 2.31.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants