fix(carriers): fix errors in another postnl carrier configuration #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
EdieLemoine
commented
Aug 1, 2024
EdieLemoine
commented
- occurs when no custom postnl contract is present but there are still multiple enabled postnl carriers returned from the api
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #292 +/- ##
=========================================
Coverage 96.22% 96.22%
+ Complexity 1665 1664 -1
=========================================
Files 307 307
Lines 5508 5509 +1
=========================================
+ Hits 5300 5301 +1
Misses 208 208 ☔ View full report in Codecov by Sentry. |
FlorianSDV
reviewed
Aug 1, 2024
tests/Unit/App/Action/Backend/Account/UpdateAccountActionTest.php
Outdated
Show resolved
Hide resolved
EdieLemoine
force-pushed
the
fix/postnl-carriers-custom-error
branch
from
e1c32c9 to
9d22752
Compare
FlorianSDV
approved these changes
Aug 1, 2024
myparcel-bot
bot
force-pushed
the
fix/postnl-carriers-custom-error
branch
from
9d22752 to
3f0f25e
Compare
myparcel-bot
bot
force-pushed
the
fix/postnl-carriers-custom-error
branch
from
19929b1 to
e375a56
Compare
EdieLemoine
force-pushed
the
fix/postnl-carriers-custom-error
branch
from
e375a56 to
82607f2
Compare
- occurs when no custom postnl contract is present but there are still multiple enabled postnl carriers returned from the api
myparcel-bot
bot
force-pushed
the
fix/postnl-carriers-custom-error
branch
from
82607f2 to
693d721
Compare
GravendeelJochem
approved these changes
Aug 14, 2024
myparcel-bot bot
added a commit
that referenced
this pull request
Aug 14, 2024
## [2.42.0](v2.41.0...v2.42.0) (2024-08-14) ### ✨ New Features * add options for small package Belgium ([#290](#290)) ([ae77717](ae77717)) * add support for DPD BBP ([#291](#291)) ([f97b148](f97b148)) ### 🐛 Bug Fixes * **carriers:** fix errors in another postnl carrier configuration ([#292](#292)) ([80134d0](80134d0))
EdieLemoine
added a commit
that referenced
this pull request
Aug 15, 2024
- occurs when no custom postnl contract is present but there are still multiple enabled postnl carriers returned from the api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.