fix(webhook): process webhook when received #313
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joerivanveen
force-pushed
the
fix/webhook/process-webhook-when-received
branch
from
16acf7a to
3f6b7aa
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #313 +/- ##
============================================
- Coverage 96.31% 95.71% -0.61%
Complexity 1688 1688
============================================
Files 315 315
Lines 5759 5759
============================================
- Hits 5547 5512 -35
- Misses 212 247 +35 ☔ View full report in Codecov by Sentry. |
FlorianSDV
approved these changes
Oct 23, 2024
myparcel-bot
bot
force-pushed
the
fix/webhook/process-webhook-when-received
branch
from
0943794 to
75c146a
Compare
myparcel-bot
bot
force-pushed
the
fix/webhook/process-webhook-when-received
branch
from
75c146a to
a4ce144
Compare
EdieLemoine
suggested changes
Oct 23, 2024
| * $this->cronService->dispatch([$this, 'processWebhook'], $input); | ||
| * For now: process immediately | ||
| */ | ||
| $this->processWebhook($input); |
There was a problem hiding this comment.
maar moet dit hier? dit kan toch gewoon in wordpress opgelost worden door dispatch dit direct te laten doen?
There was a problem hiding this comment.
Ok ik sluit de pr, ik deed het hier om 100% zeker te zijn dat het in alle platformen zou werken, en dat ik niet alleen een fix voor WordPress zou maken.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INT-572