Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(checkout): show carriers only for countries they ship to #273

Merged
merged 6 commits into from
Nov 15, 2024

Conversation

EdieLemoine
Copy link
Contributor

@EdieLemoine EdieLemoine commented Sep 26, 2024

INT-704

@EdieLemoine EdieLemoine requested a review from a team as a code owner September 26, 2024 14:49
@myparcel-bot myparcel-bot bot force-pushed the feat/countries-per-carrier branch from dadf226 to f06a031 Compare September 26, 2024 14:57
src/Hooks/HasPsCarrierListHooks.php Show resolved Hide resolved
src/Hooks/HasPsCarrierListHooks.php Outdated Show resolved Hide resolved
src/Service/PsCountryService.php Show resolved Hide resolved
src/Service/PsCountryService.php Show resolved Hide resolved
tests/factories/StateFactory.php Outdated Show resolved Hide resolved
@myparcel-bot myparcel-bot bot added the changes requested (Auto) label Sep 27, 2024
@myparcel-bot myparcel-bot bot removed the changes requested (Auto) label Sep 27, 2024
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 87.09677% with 12 lines in your changes missing coverage. Please review.

Project coverage is 49.26%. Comparing base (76d8be2) to head (769d970).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/Service/PsSpecificObjectModelService.php 0.00% 4 Missing ⚠️
src/Carrier/Service/CarrierBuilder.php 75.00% 2 Missing ⚠️
src/Hooks/HasPsCarrierListHooks.php 94.44% 2 Missing ⚠️
src/Pdk/Base/PsPdkBootstrapper.php 60.00% 2 Missing ⚠️
src/Service/PsCountryService.php 92.59% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #273      +/-   ##
============================================
- Coverage     52.27%   49.26%   -3.01%     
+ Complexity      690      602      -88     
============================================
  Files           152      151       -1     
  Lines          4199     3897     -302     
  Branches         55       55              
============================================
- Hits           2195     1920     -275     
+ Misses         1949     1922      -27     
  Partials         55       55              
Flag Coverage Δ
backend 76.89% <87.09%> (-1.53%) ⬇️
frontend 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@myparcel-bot myparcel-bot bot added the approved (Auto) label Sep 27, 2024
@myparcel-bot
Copy link
Contributor

myparcel-bot bot commented Sep 27, 2024

PDK upgrade summary

The following packages were upgraded:

Package Old version New version
myparcelnl/pdk 2.42.0 2.43.4

@myparcel-bot
Copy link
Contributor

myparcel-bot bot commented Sep 27, 2024

✅ Build successful!

You can find a link to the downloadable artifact below.

Name Link
Commit 769d970
Logs https://github.com/myparcelnl/prestashop/actions/runs/11820717603
Download https://github.com/myparcelnl/prestashop/suites/30845815609/artifacts/2182781687

@myparcel-bot myparcel-bot bot force-pushed the feat/countries-per-carrier branch 4 times, most recently from e2fa717 to 62df26a Compare October 4, 2024 11:24
@myparcel-bot myparcel-bot bot force-pushed the feat/countries-per-carrier branch 14 times, most recently from 82aa17d to d386d2f Compare October 11, 2024 12:45
@myparcel-bot myparcel-bot bot force-pushed the feat/countries-per-carrier branch from d386d2f to a9164ee Compare October 16, 2024 10:23
@myparcel-bot myparcel-bot bot force-pushed the feat/countries-per-carrier branch 2 times, most recently from 9b6060a to 0025429 Compare October 16, 2024 10:35
@EdieLemoine EdieLemoine changed the base branch from beta to main October 16, 2024 11:35
@myparcel-bot myparcel-bot bot force-pushed the feat/countries-per-carrier branch 3 times, most recently from 81efa95 to 9960536 Compare October 23, 2024 10:16
@myparcel-bot myparcel-bot bot force-pushed the feat/countries-per-carrier branch 5 times, most recently from 456d3fd to 5035d29 Compare October 30, 2024 18:08
@EdieLemoine EdieLemoine force-pushed the feat/countries-per-carrier branch from 5035d29 to 0b58770 Compare November 7, 2024 13:35
@myparcel-bot myparcel-bot bot force-pushed the feat/countries-per-carrier branch from 0b58770 to 7138881 Compare November 7, 2024 13:58
@EdieLemoine EdieLemoine force-pushed the feat/countries-per-carrier branch from 7138881 to f72a9d8 Compare November 13, 2024 14:37
@EdieLemoine EdieLemoine force-pushed the feat/countries-per-carrier branch from f72a9d8 to 769d970 Compare November 13, 2024 15:43
@FreekVR FreekVR added this pull request to the merge queue Nov 15, 2024
Merged via the queue into main with commit e13b6a2 Nov 15, 2024
6 of 7 checks passed
@FreekVR FreekVR deleted the feat/countries-per-carrier branch November 15, 2024 09:57
myparcel-bot bot added a commit that referenced this pull request Nov 20, 2024
## [4.2.0](v4.1.0...v4.2.0) (2024-11-20)

### 🐛 Bug Fixes

* **admin:** fix toggle and tristate input elements not working correctly ([#278](#278)) ([c8832fd](c8832fd)), closes [myparcelnl/js-pdk#223](myparcelnl/js-pdk#223)
* **orders:** export correct recipient name ([#277](#277)) ([883dcf4](883dcf4)), closes [#276](#276)
* **upgrade:** always execute module installation on upgrade ([#271](#271)) ([78b3657](78b3657))

### ✨ New Features

* **backend:** add download logs action ([#275](#275)) ([7bb1349](7bb1349)), closes [myparcelnl/pdk#288](myparcelnl/pdk#288) [myparcelnl/js-pdk#221](myparcelnl/js-pdk#221)
* **checkout:** show carriers only for countries they ship to ([#273](#273)) ([e13b6a2](e13b6a2))
* **deps:** upgrade @myparcel-pdk/checkout to v1.2.0 ([0b314e9](0b314e9))
* **deps:** upgrade myparcelnl/pdk to v2.47.1 ([ffe8ce4](ffe8ce4))
@myparcel-bot
Copy link
Contributor

myparcel-bot bot commented Nov 20, 2024

🎉 This PR is included in version 4.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants