fix(admin): fix toggle and tristate input elements not working correctly #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
EdieLemoine
commented
Oct 10, 2024
•
EdieLemoine
commented
- Fixes "disable delivery options" in product settings not being saved
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #278 +/- ##
============================================
- Coverage 51.96% 48.06% -3.90%
+ Complexity 690 561 -129
============================================
Files 152 148 -4
Lines 4191 3728 -463
Branches 55 55
============================================
- Hits 2178 1792 -386
+ Misses 1958 1881 -77
Partials 55 55
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
EdieLemoine
force-pushed
the
fix/fix-product-settings-saving
branch
from
90a9165 to
5a866d3
Compare
EdieLemoine
changed the title
joerivanveen
approved these changes
Oct 10, 2024
FlorianSDV
reviewed
Oct 11, 2024
FreekVR
approved these changes
Oct 11, 2024
EdieLemoine
force-pushed
the
fix/fix-product-settings-saving
branch
from
5a866d3 to
fef0909
Compare
myparcel-bot
bot
force-pushed
the
fix/fix-product-settings-saving
branch
4 times, most recently
from
da57535 to
b01decf
Compare
|
✅ Build successful! You can find a link to the downloadable artifact below.
|
myparcel-bot
bot
force-pushed
the
fix/fix-product-settings-saving
branch
from
b01decf to
430ad55
Compare
- Fixes "disable delivery options" in product settings not being saved Needs myparcelnl/js-pdk#223
myparcel-bot
bot
force-pushed
the
fix/fix-product-settings-saving
branch
from
430ad55 to
b176ed4
Compare
myparcel-bot bot
added a commit
that referenced
this pull request
Nov 20, 2024
## [4.2.0](v4.1.0...v4.2.0) (2024-11-20) ### 🐛 Bug Fixes * **admin:** fix toggle and tristate input elements not working correctly ([#278](#278)) ([c8832fd](c8832fd)), closes [myparcelnl/js-pdk#223](myparcelnl/js-pdk#223) * **orders:** export correct recipient name ([#277](#277)) ([883dcf4](883dcf4)), closes [#276](#276) * **upgrade:** always execute module installation on upgrade ([#271](#271)) ([78b3657](78b3657)) ### ✨ New Features * **backend:** add download logs action ([#275](#275)) ([7bb1349](7bb1349)), closes [myparcelnl/pdk#288](myparcelnl/pdk#288) [myparcelnl/js-pdk#221](myparcelnl/js-pdk#221) * **checkout:** show carriers only for countries they ship to ([#273](#273)) ([e13b6a2](e13b6a2)) * **deps:** upgrade @myparcel-pdk/checkout to v1.2.0 ([0b314e9](0b314e9)) * **deps:** upgrade myparcelnl/pdk to v2.47.1 ([ffe8ce4](ffe8ce4))
|
🎉 This PR is included in version 4.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.