Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(install): fix error when creating audit table #288

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

FreekVR
Copy link
Collaborator

@FreekVR FreekVR commented Nov 22, 2024

fixes a duplicate column error when attempting to create the audit database table on install or upgrade, which potentially also blocks other database migrations from being executed

fixes INT-735, #287

@FreekVR FreekVR requested a review from a team as a code owner November 22, 2024 09:54
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.30%. Comparing base (df8260e) to head (cc2b2d4).
Report is 5 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #288      +/-   ##
============================================
- Coverage     52.57%   49.30%   -3.27%     
+ Complexity      709      602     -107     
============================================
  Files           152      151       -1     
  Lines          4234     3896     -338     
  Branches         55       55              
============================================
- Hits           2226     1921     -305     
+ Misses         1953     1920      -33     
  Partials         55       55              
Flag Coverage Δ
backend 76.96% <ø> (-1.59%) ⬇️
frontend 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@myparcel-bot
Copy link
Contributor

myparcel-bot bot commented Nov 22, 2024

PDK upgrade summary

♻️ The following packages were upgraded (from cache):

Package Old version New version
@myparcel-pdk/admin 1.5.3 1.5.4
@myparcel-pdk/admin-component-tests 1.5.3 1.5.4
@myparcel-pdk/admin-preset-bootstrap4 1.5.3 1.5.4
@myparcel-pdk/admin-preset-default 1.5.3 1.5.4
@myparcel-pdk/app-builder 1.6.0 1.6.1
myparcelnl/pdk 2.47.1 2.47.2

@myparcel-bot myparcel-bot bot force-pushed the fix/error-creating-audit-table-on-install branch from cf93884 to 3b1c426 Compare November 22, 2024 10:34
@FreekVR FreekVR force-pushed the fix/error-creating-audit-table-on-install branch from 3b1c426 to d344158 Compare November 22, 2024 11:13
@myparcel-bot myparcel-bot bot force-pushed the fix/error-creating-audit-table-on-install branch from d344158 to d95c5b1 Compare November 22, 2024 13:25
@myparcel-bot
Copy link
Contributor

myparcel-bot bot commented Nov 22, 2024

✅ Build successful!

You can find a link to the downloadable artifact below.

Name Link
Commit cc2b2d4
Logs https://github.com/myparcelnl/prestashop/actions/runs/11974763646
Download https://github.com/myparcelnl/prestashop/suites/31219628615/artifacts/2224745315

fixes a duplicate column error when attempting to create the audit database table on install or upgrade
@myparcel-bot myparcel-bot bot force-pushed the fix/error-creating-audit-table-on-install branch from d95c5b1 to cc2b2d4 Compare November 22, 2024 14:45
@myparcel-bot myparcel-bot bot added the approved (Auto) label Nov 25, 2024
@FreekVR FreekVR added this pull request to the merge queue Nov 25, 2024
@FreekVR FreekVR removed this pull request from the merge queue due to a manual request Nov 25, 2024
@FreekVR FreekVR added this pull request to the merge queue Nov 27, 2024
Merged via the queue into main with commit d519ed2 Nov 27, 2024
11 of 12 checks passed
@FreekVR FreekVR deleted the fix/error-creating-audit-table-on-install branch November 27, 2024 08:47
myparcel-bot bot added a commit that referenced this pull request Nov 27, 2024
## [4.2.1](v4.2.0...v4.2.1) (2024-11-27)

### 🐛 Bug Fixes

* **deps:** upgrade @myparcel-pdk/* ([c0b3138](c0b3138))
* **deps:** upgrade myparcelnl/pdk to v2.47.2 ([bb765ba](bb765ba))
* **install:** fix error when creating audit table ([#288](#288)) ([d519ed2](d519ed2))
@myparcel-bot
Copy link
Contributor

myparcel-bot bot commented Nov 27, 2024

🎉 This PR is included in version 4.2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@FreekVR FreekVR linked an issue Nov 27, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Invalid API key error message
3 participants