revert: revert unnecessary change

Refs: c5b720c.
myparcelnl · Jun 27, 2024 · be0b704 · be0b704
1 parent 624273d
commit be0b704
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 21 deletions.
diff --git a/src/Model/Consignment/AbstractConsignment.php b/src/Model/Consignment/AbstractConsignment.php
@@ -227,16 +227,6 @@ abstract class AbstractConsignment
      */
     public const LABEL_DESCRIPTION_MAX_LENGTH = 45;
 
-    /**
-     * @var int
-     */
-    public const PERSON_NAME_MAX_LENGTH = 500;
-
-    /**
-     * @var int
-     */
-    public const COMPANY_NAME_MAX_LENGTH = 500;
-
     /**
      * @internal
      * @var null|string
@@ -1241,7 +1231,7 @@ public function getPerson(): string
      */
     public function setPerson(string $person): self
     {
-        $this->person = substr($person, -self::PERSON_NAME_MAX_LENGTH);
+        $this->person = $person;
 
         return $this;
     }
@@ -1264,10 +1254,6 @@ public function getCompany(): ?string
      */
     public function setCompany(?string $company): self
     {
-        if (isset($company)) {
-            $company = substr($company, -self::COMPANY_NAME_MAX_LENGTH);
-        }
-
         $this->company = $company;
 
         return $this;

diff --git a/src/Model/Consignment/UPSConsignment.php b/src/Model/Consignment/UPSConsignment.php
@@ -11,11 +11,6 @@ class UPSConsignment extends AbstractConsignment
 {
     public const DEFAULT_WEIGHT = 3000;
 
-    /**
-     * @var int
-     */
-    public const PERSON_NAME_MAX_LENGTH = 35;
-
     /**
      * @internal
      * @var int

diff --git a/test/Model/Consignment/DHLForYouConsignmentTest.php b/test/Model/Consignment/DHLForYouConsignmentTest.php
@@ -50,7 +50,6 @@ public function provideDHLForYouConsignmentsData(): array
      */
     public function testDHLForYouConsignments(array $testData): void
     {
-        $this->markTestSkipped('Skip because of DHL api error');
         $this->doConsignmentTest($testData);
     }
-Original file line number
+Diff line change
@@ Expand Up / @@ -50,7 +50,6 @@ public function provideDHLForYouConsignmentsData(): array @@
          */
         public function testDHLForYouConsignments(array $testData): void
         {
-            $this->markTestSkipped('Skip because of DHL api error');
             $this->doConsignmentTest($testData);
         }
@@ Expand Down @@