Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new way of declaring forms #218

Merged
merged 23 commits into from
Nov 21, 2023
Merged

Conversation

EdieLemoine
Copy link
Contributor

@EdieLemoine EdieLemoine commented Nov 13, 2023

No description provided.

@EdieLemoine EdieLemoine changed the title wip new form structure wip: new form structure Nov 13, 2023
@EdieLemoine EdieLemoine marked this pull request as ready for review November 20, 2023 11:54
@EdieLemoine EdieLemoine requested review from a team as code owners November 20, 2023 11:54
@EdieLemoine EdieLemoine changed the title wip: new form structure feat: add new form declaration structure Nov 20, 2023
@EdieLemoine EdieLemoine changed the title feat: add new form declaration structure feat: add new way of declaring forms Nov 20, 2023
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Attention: 149 lines in your changes are missing coverage. Please review.

Comparison is base (6a55317) 84.81% compared to head (4b6aeb9) 79.82%.
Report is 1 commits behind head on beta.

Files Patch % Lines
libs/core/src/form/createField.ts 31.74% 86 Missing ⚠️
libs/core/src/form/generateFieldName.ts 19.23% 21 Missing ⚠️
libs/core/src/form/Form.ts 9.09% 10 Missing ⚠️
libs/core/src/components/MagicForm.vue 71.87% 3 Missing and 6 partials ⚠️
libs/core/src/form/createForm.ts 55.00% 9 Missing ⚠️
libs/core/src/components/RenderedFormContent.vue 85.36% 2 Missing and 4 partials ⚠️
...src/form/interactive-element/InteractiveElement.ts 50.00% 2 Missing and 1 partial ⚠️
libs/core/src/components/FormElementWrapper.ts 60.00% 1 Missing and 1 partial ⚠️
libs/core/src/composables/useFormBuilder.ts 87.50% 2 Missing ⚠️
libs/core/src/components/FormElement.vue 94.44% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             beta     #218      +/-   ##
==========================================
- Coverage   84.81%   79.82%   -5.00%     
==========================================
  Files          35       39       +4     
  Lines        1739     1973     +234     
  Branches      153      158       +5     
==========================================
+ Hits         1475     1575     +100     
- Misses        113      242     +129     
- Partials      151      156       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EdieLemoine EdieLemoine added this pull request to the merge queue Nov 21, 2023
Merged via the queue into beta with commit 9546c82 Nov 21, 2023
2 of 4 checks passed
@EdieLemoine EdieLemoine deleted the wip-new-form-structure branch November 21, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants